aries-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Holly Cummins <cummi...@uk.ibm.com>
Subject Re: AriesBundleTrackerCustomizer.java in aries util in empty
Date Fri, 14 May 2010 19:55:10 GMT
Hi Lin, 

That's exactly what I did, unfortunately. I guess I'll know for next time 
to add an explicit comment along with the patch mentioning that files have 
been deleted. 

Thanks, 
Holly
--

Phone: External +44 (0) 1962 815104 ; Internal 7-245104;



Lin Sun <linsun.unc@gmail.com> 
05/14/2010 09:12 PM
Please respond to
aries-user@incubator.apache.org


To
aries-user@incubator.apache.org
cc

Subject
Re: AriesBundleTrackerCustomizer.java in aries util in empty






Hi Holly

No prob.  I have removed the empty files.

For example, if you want to delete a file, you do:

svn delete filename

Then you do svn diff to create your patch, and you should see the file 
deleted, like below:

linsun@dyn9-37-240-133:~/ariesN/trunk/samples/blog>svn delete pom.xml 
D         pom.xml

linsun@dyn9-37-240-133:~/ariesN/trunk/samples/blog>svn diff
Index: pom.xml
===================================================================
--- pom.xml    (revision 944247)
+++ pom.xml    (working copy)
@@ -1,95 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<!--
-    Licensed to the Apache Software Foundation (ASF) under one or more
-    contributor license agreements.  See the NOTICE file distributed with

If this is what you did, then maybe this is a natural limitation of patch 
:-(

Lin

On Fri, May 14, 2010 at 3:03 PM, Holly Cummins <cumminsh@uk.ibm.com> 
wrote:
Hi, 

Those zero-size files are my fault - sorry! -  but I agree with Jeremy 
that they shouldn't be responsible for the ClassNotFoundException. I guess 
we better raise a tracker to clear out the empty files, just in the 
interests of code cleanliness. (Now done - ARIES-312.) 

When I made my patch with svn diff, no amount of 'svn delete' would give a 
patch which when applied produced anything other than an empty file. Is 
this a natural limitation of the patch format, or did I miss a step 
creating the patch? 

Cheers, 
Holly 



Jeremy Hughes <hughesj@apache.org> 
Sent by: jpjhughes@gmail.com 
05/14/2010 11:30 AM 


Please respond to
aries-user@incubator.apache.org


To
aries-user@incubator.apache.org 
cc

Subject
Re: AriesBundleTrackerCustomizer.java in aries util in empty








Hi, it looks like r941776 should have deleted those .java files
instead of clearing them out to 0 bytes. However, this isn't causing
the NoClassDefFoundError. I feel you are getting that because the
level of the BlueprintExtender class you are using is old.

Either

* your checkout of the blueprint module isn't at HEAD (unlikely since
you said you had checked out the trunk)
* the blueprint bundle in you local maven repo are out of date and you
need to rebuild the blueprint module
* the blueprint bundle in your trunk/samples/blog/blog-assembly/target
is out of date compared with the one in your local maven repo and you
need to mvn clean install the blog-assembly module.
* none of the above :-) but I'm pretty certain the
trunk/samples/blog/blog-assembly/target/org.apache.aries.blueprint-0.2-incubating-SNAPSHOT.jar
you have doesn't contain the latest BlueprintExtender class.

Cheers,
Jeremy

On 14 May 2010 09:54, Jeremy Hughes <hughesj@apache.org> wrote:
> Hi thanks for letting us know. I can see the file has been emptied out
> along with some others, like you say in r941776 / ARIES-272.
>
> I'll fix.
>
> Thanks,
> Jeremy
>
> On 14 May 2010 08:54, Ivanhoe Abrahams <ivanhoeabrahams@gmail.com> 
wrote:
>> Hi all,
>>
>> This is my first post to this mailing list, :-)
>>
>> I have checked out aries trunk, as explained on the website, and built 
it,
>> everything went fine.
>> However when i proceeded to build and run the blog sample app. I get 
the
>> following error on start up, and consequently deploying the .eba  as
>> explaind does not do anything.
>>
>> Below is the exception when starting the osgi container.
>>
>> [Framework Event Dispatcher] DEBUG org.apache.aries.blueprint -
>> FrameworkEvent ERROR
>> org.osgi.framework.BundleException: Exception in
>> org.apache.aries.blueprint.container.BlueprintExtender.start() of 
bundle
>> org.apache.aries.blueprint.
>>     at
>> 
org.eclipse.osgi.framework.internal.core.BundleContextImpl.startActivator(BundleContextImpl.java:805)
>>     at
>> 
org.eclipse.osgi.framework.internal.core.BundleContextImpl.start(BundleContextImpl.java:754)
>>     at
>> 
org.eclipse.osgi.framework.internal.core.BundleHost.startWorker(BundleHost.java:352)
>>     at
>> 
org.eclipse.osgi.framework.internal.core.AbstractBundle.resume(AbstractBundle.java:370)
>>     at
>> 
org.eclipse.osgi.framework.internal.core.Framework.resumeBundle(Framework.java:1068)
>>     at
>> 
org.eclipse.osgi.framework.internal.core.StartLevelManager.resumeBundles(StartLevelManager.java:557)
>>     at
>> 
org.eclipse.osgi.framework.internal.core.StartLevelManager.incFWSL(StartLevelManager.java:464)
>>     at
>> 
org.eclipse.osgi.framework.internal.core.StartLevelManager.doSetStartLevel(StartLevelManager.java:248)
>>     at
>> 
org.eclipse.osgi.framework.internal.core.StartLevelManager.dispatchEvent(StartLevelManager.java:445)
>>     at
>> 
org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:220)
>>     at
>> 
org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:330)
>> Caused by: java.lang.NoClassDefFoundError:
>> org/apache/aries/util/tracker/AriesBundleTrackerCustomizer
>>     at java.lang.ClassLoader.defineClass1(Native Method)
>>     at java.lang.ClassLoader.defineClassCond(ClassLoader.java:632)
>>     at java.lang.ClassLoader.defineClass(ClassLoader.java:616)
>>     at
>> 
org.eclipse.osgi.internal.baseadaptor.DefaultClassLoader.defineClass(DefaultClassLoader.java:183)
>>     at
>> 
org.eclipse.osgi.baseadaptor.loader.ClasspathManager.defineClass(ClasspathManager.java:576)
>>     at
>> 
org.eclipse.osgi.baseadaptor.loader.ClasspathManager.findClassImpl(ClasspathManager.java:546)
>>     at
>> 
org.eclipse.osgi.baseadaptor.loader.ClasspathManager.findLocalClassImpl(ClasspathManager.java:477)
>>     at
>> 
org.eclipse.osgi.baseadaptor.loader.ClasspathManager.findLocalClass_LockClassLoader(ClasspathManager.java:465)
>>     at
>> 
org.eclipse.osgi.baseadaptor.loader.ClasspathManager.findLocalClass(ClasspathManager.java:445)
>>     at
>> 
org.eclipse.osgi.internal.baseadaptor.DefaultClassLoader.findLocalClass(DefaultClassLoader.java:211)
>>     at
>> 
org.eclipse.osgi.internal.loader.BundleLoader.findLocalClass(BundleLoader.java:376)
>>     at
>> 
org.eclipse.osgi.internal.loader.BundleLoader.findClassInternal(BundleLoader.java:452)
>>     at
>> 
org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:405)
>>     at
>> 
org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:393)
>>     at
>> 
org.eclipse.osgi.internal.baseadaptor.DefaultClassLoader.loadClass(DefaultClassLoader.java:105)
>>     at java.lang.ClassLoader.loadClass(ClassLoader.java:248)
>>     at
>> 
org.apache.aries.blueprint.container.BlueprintExtender.start(BlueprintExtender.java:88)
>>     at
>> 
org.eclipse.osgi.framework.internal.core.BundleContextImpl$1.run(BundleContextImpl.java:782)
>>     at java.security.AccessController.doPrivileged(Native Method)
>>     at
>> 
org.eclipse.osgi.framework.internal.core.BundleContextImpl.startActivator(BundleContextImpl.java:773)
>>     ... 10 more
>> Caused by: java.lang.ClassNotFoundException:
>> org.apache.aries.util.tracker.AriesBundleTrackerCustomizer
>>     at
>> 
org.eclipse.osgi.internal.loader.BundleLoader.findClassInternal(BundleLoader.java:489)
>>     at
>> 
org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:405)
>>     at
>> 
org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:393)
>>     at
>> 
org.eclipse.osgi.internal.baseadaptor.DefaultClassLoader.loadClass(DefaultClassLoader.java:105)
>>     at java.lang.ClassLoader.loadClass(ClassLoader.java:248)
>>     ... 30 more
>>
>> I checked the code for class
>> org.apache.aries.util.tracker.AriesBundleTrackerCustomizer...But that 
class
>> is absolutely empty. In other words the .java file contains nothing, 
and as
>> a result the compiler does not generate a .class file for it, hence the
>> ClassNotFoundException...
>>
>> By the way there are 2 more .java files in that package that are empty 
as
>> well
>>
>> I am sure this was just a bad commit by somebody.
>>
>> Thanx
>> Ivanhoe
>>
>>
>>
>>
>>
>






Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 
741598. 
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU 













Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 
741598. 
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU






Mime
View raw message