aries-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bdelacretaz <>
Subject [GitHub] aries-containers pull request #1: Suggesting a different way of writing the ...
Date Wed, 27 Sep 2017 07:50:42 GMT
GitHub user bdelacretaz opened a pull request:

    Suggesting a different way of writing the Builder

    Here's a suggestion for a different way of writing Builders, which avoids duplicating
member variables. The downside is that those can't be made final anymore, but as the class
doesn't have setters I don't think that's a problem.
    As mentioned this is just a suggestion, feel free to ignore! I was just curious how this
would work and maybe this is useful, but if not it's no big deal.
    All tests pass but the `makeUnmodifiable` method's lockdown of collections is not currently
covered by tests.

You can merge this pull request into a Git repository by running:

    $ git pull builder-suggestion

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1
commit 4d335dfafaa4b7ffb6c868aef2a2e0f7b6f97883
Author: Bertrand Delacretaz <>
Date:   2017-09-27T07:46:28Z

    A different way of writing the Builder, which avoids duplicating the member variables



View raw message