Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6B037200C86 for ; Wed, 31 May 2017 23:15:09 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 6965E160BCB; Wed, 31 May 2017 21:15:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B0587160BC2 for ; Wed, 31 May 2017 23:15:08 +0200 (CEST) Received: (qmail 12948 invoked by uid 500); 31 May 2017 21:15:07 -0000 Mailing-List: contact dev-help@aries.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@aries.apache.org Delivered-To: mailing list dev@aries.apache.org Received: (qmail 12936 invoked by uid 99); 31 May 2017 21:15:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 31 May 2017 21:15:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 7CE2EC0EEE for ; Wed, 31 May 2017 21:15:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id foMhrzFhufh2 for ; Wed, 31 May 2017 21:15:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 5B5085FBE5 for ; Wed, 31 May 2017 21:15:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 95EC4E0BDE for ; Wed, 31 May 2017 21:15:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4346B21B57 for ; Wed, 31 May 2017 21:15:04 +0000 (UTC) Date: Wed, 31 May 2017 21:15:04 +0000 (UTC) From: "Thomas Watson (JIRA)" To: dev@aries.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (ARIES-1729) Including resources with no manifest or bundle symbolic names causes NPE MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 31 May 2017 21:15:09 -0000 [ https://issues.apache.org/jira/browse/ARIES-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Watson resolved ARIES-1729. ---------------------------------- Resolution: Fixed > Including resources with no manifest or bundle symbolic names causes NPE > ------------------------------------------------------------------------ > > Key: ARIES-1729 > URL: https://issues.apache.org/jira/browse/ARIES-1729 > Project: Aries > Issue Type: Bug > Components: Subsystem > Reporter: Thomas Watson > Assignee: Thomas Watson > > The following NPE happens if you have a resource with no bundle manifest: > {code} > java.lang.NullPointerException > at org.apache.aries.subsystem.core.internal.BundleResource.computeManifest(BundleResource.java:62) > at org.apache.aries.subsystem.core.internal.BundleResource.(BundleResource.java:73) > at org.apache.aries.subsystem.core.internal.RawSubsystemResource.addResource(RawSubsystemResource.java:499) > at org.apache.aries.subsystem.core.internal.RawSubsystemResource.computeResources(RawSubsystemResource.java:459) > at org.apache.aries.subsystem.core.internal.RawSubsystemResource.(RawSubsystemResource.java:134) > at org.apache.aries.subsystem.core.internal.SubsystemResource.(SubsystemResource.java:91) > at org.apache.aries.subsystem.core.internal.InstallAction.run(InstallAction.java:60) > at org.apache.aries.subsystem.core.internal.InstallAction.run(InstallAction.java:27) > at java.security.AccessController.doPrivileged(Native Method) > at org.apache.aries.subsystem.core.internal.BasicSubsystem.install(BasicSubsystem.java:677) > at org.apache.aries.subsystem.core.internal.BasicSubsystem.install(BasicSubsystem.java:671) > at com.ibm.ws.app.manager.esa.internal.DeploySubsystemAction.installSubsystem(DeploySubsystemAction.java:190) > at com.ibm.ws.app.manager.esa.internal.DeploySubsystemAction.deploySubsystem(DeploySubsystemAction.java:163) > at com.ibm.ws.app.manager.esa.internal.DeploySubsystemAction.deploy(DeploySubsystemAction.java:113) > at com.ibm.ws.app.manager.esa.internal.SubsystemHandler.install(SubsystemHandler.java:356) > at com.ibm.ws.app.manager.esa.internal.EBAToSubsystemHandler.install(EBAToSubsystemHandler.java:194) > at com.ibm.ws.app.manager.internal.statemachine.StartAction.execute(StartAction.java:141) > at com.ibm.ws.app.manager.internal.statemachine.ApplicationStateMachineImpl.enterState(ApplicationStateMachineImpl.java:1259) > at com.ibm.ws.app.manager.internal.statemachine.ApplicationStateMachineImpl.run(ApplicationStateMachineImpl.java:874) > at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > at java.lang.Thread.run(Thread.java:748) > {code} > The following happens if a jar resource is included in the ESA which has no Bundle-SymbolicName header: > {code} > java.lang.NullPointerException > at org.apache.aries.subsystem.core.archive.FragmentHostCapability.initializeAttributes(FragmentHostCapability.java:38) > at org.apache.aries.subsystem.core.archive.FragmentHostCapability.(FragmentHostCapability.java:67) > at org.apache.aries.subsystem.core.internal.BundleResource.computeOsgiWiringHostCapability(BundleResource.java:191) > at org.apache.aries.subsystem.core.internal.BundleResource.computeRequirementsOtherThanService(BundleResource.java:245) > at org.apache.aries.subsystem.core.internal.BundleResource.computeRequirementsAndCapabilities(BundleResource.java:216) > at org.apache.aries.subsystem.core.internal.BundleResource.(BundleResource.java:74) > at org.apache.aries.subsystem.core.internal.RawSubsystemResource.addResource(RawSubsystemResource.java:472) > at org.apache.aries.subsystem.core.internal.RawSubsystemResource.computeResources(RawSubsystemResource.java:457) > at org.apache.aries.subsystem.core.internal.RawSubsystemResource.(RawSubsystemResource.java:134) > at org.apache.aries.subsystem.core.internal.SubsystemResource.(SubsystemResource.java:91) > at org.apache.aries.subsystem.core.internal.InstallAction.run(InstallAction.java:60) > {code} > In both cases we should give a good exception message to log and simply ignore the resource and continue on installing the subsystem. -- This message was sent by Atlassian JIRA (v6.3.15#6346)