Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C30C7200C62 for ; Wed, 26 Apr 2017 19:22:07 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id C1A8E160BA8; Wed, 26 Apr 2017 17:22:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 14F8E160B8F for ; Wed, 26 Apr 2017 19:22:06 +0200 (CEST) Received: (qmail 88695 invoked by uid 500); 26 Apr 2017 17:22:06 -0000 Mailing-List: contact dev-help@aries.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@aries.apache.org Delivered-To: mailing list dev@aries.apache.org Received: (qmail 88684 invoked by uid 99); 26 Apr 2017 17:22:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Apr 2017 17:22:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id E0DE1D5550 for ; Wed, 26 Apr 2017 17:22:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id R6597t6sGMwP for ; Wed, 26 Apr 2017 17:22:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 38B195FAFA for ; Wed, 26 Apr 2017 17:22:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B85B7E0BB3 for ; Wed, 26 Apr 2017 17:22:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1BCD521DE0 for ; Wed, 26 Apr 2017 17:22:04 +0000 (UTC) Date: Wed, 26 Apr 2017 17:22:04 +0000 (UTC) From: "Dominik Przybysz (JIRA)" To: dev@aries.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (ARIES-1712) Blueprint maven plugin: common code in transaction factories MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 26 Apr 2017 17:22:07 -0000 [ https://issues.apache.org/jira/browse/ARIES-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dominik Przybysz resolved ARIES-1712. ------------------------------------- Resolution: Done I have refactored javax factories and extracted abstract class. Spring transaction factory is left without change, because it is in another module. > Blueprint maven plugin: common code in transaction factories > ------------------------------------------------------------ > > Key: ARIES-1712 > URL: https://issues.apache.org/jira/browse/ARIES-1712 > Project: Aries > Issue Type: Improvement > Components: Blueprint > Reporter: Andrei Shakirin > Assignee: Dominik Przybysz > Fix For: blueprint-maven-plugin-1.7.0 > > > blueprint maven plugin uses following factories to proceed different kind of transaction annotations: JavaxTransactionFactory, CdiTransactionFactory, CdiTransactionFactory. > Basically factories implement very similar functionality triggered by different kind of annotation classes. > Currently these transacation factories are decoupled one from other, but they repeat a lot of code: namespace handling, attribute writer, etc. > Proposal: refactor common functionality either to delegate helper or to abstract class. In case if proposal sounds reasonable for you, I will provide the patch. -- This message was sent by Atlassian JIRA (v6.3.15#6346)