aries-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Bosschaert (JIRA)" <>
Subject [jira] [Commented] (ARIES-953) SPIFly: SPI-Consumer breaks when method has multiple parameters
Date Thu, 08 Oct 2015 09:10:27 GMT


David Bosschaert commented on ARIES-953:

Sorry for the long time it took me to look at this patch. I am just looking at it and I'm
not sure I fully understand the changed regular expression with its escapes and modifier.

Would it be possible to also provide a unit test that actually exercises this code and shows
what situations it is for? 

> SPIFly: SPI-Consumer breaks when method has multiple parameters
> ---------------------------------------------------------------
>                 Key: ARIES-953
>                 URL:
>             Project: Aries
>          Issue Type: Bug
>    Affects Versions: 1.0
>         Environment: o.a.a.spifly.dynamic.bundle-1.0.0-20121027.033140-20
> Eclipse 4.2
>            Reporter: Kevin Milburn
>            Assignee: David Bosschaert
>         Attachments:
> If a method used on the SPI-Consumer header contains multiple parameters, an erroneous
exception is generated.
> e.g.  
>  SPI-Consumer: o.a.x.u.Service#providers(java.lang.Class,boolean)
> generates 
>  Must at least specify class name and method name: boolean
> While the has code to deal with multiple parameters, the
call to HeaderParser.parseHeader breaks the string incorrectly.

This message was sent by Atlassian JIRA

View raw message