Mailing-List: contact dev-help@aries.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@aries.apache.org
Date: Tue, 22 Sep 2015 13:31:04 +0000 (UTC)
From: "Matthew Pitts (JIRA)" <jira@apache.org>
To: dev@aries.apache.org
Message-ID: <JIRA.12895450.1442928639000.38601.1442928664337@Atlassian.JIRA>
In-Reply-To: <JIRA.12895450.1442928639000@Atlassian.JIRA>
References: <JIRA.12895450.1442928639000@Atlassian.JIRA>
 <JIRA.12895450.1442928639009@arcas>
Subject: [jira] [Created] (ARIES-1415) Exception laundering in JpaTemplate
 impls
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

Matthew Pitts created ARIES-1415:
------------------------------------

             Summary: Exception laundering in JpaTemplate impls
                 Key: ARIES-1415
                 URL: https://issues.apache.org/jira/browse/ARIES-1415
             Project: Aries
          Issue Type: Improvement
          Components: JPA
    Affects Versions: jpa-2.2.0
            Reporter: Matthew Pitts


Currently XaJpaTemplate and ResourceLocalJpaTemplate wrap all caught exceptions in a  new RuntimeException and throw that instead of the original. This can make it problematic to integrate with code that wants to run txExpr methods and catch specific exceptions - like NoResultException or other type of recoverable exception.

Perhaps a method (like launderTxException) could be added to their base class - AbstractJpaTemplate - which could allow for additional exception laundering.

Specifically, I thinking of something that would actually attempt to instantiate a new instance of the original exception type via reflection and populate it with the necessary detail message. If it is unable to instantiate the original exception, then it can simply rethrow it as-is or maintain the original behavior of wrapping it in a RuntimeException.

Something like this:

{code}
protected RuntimeException launderTxException(Throwable original, String message) {
        if (RuntimeException.class.isInstance(original)) {
            return wrapTxException(RuntimeException.class.cast(original), message);
        }
        else {
            return new RuntimeException(message, original);
        }
    }

    protected RuntimeException wrapTxException(RuntimeException original, String message) {
        if (message == null)
            return original;

        try {
            RuntimeException wrapper = original.getClass().getConstructor(new Class[]
            { String.class }).newInstance(message);
            wrapper.initCause(original);
            return wrapper;
        }
        catch (ReflectiveOperationException e) {
            return original;
        }
    }
{code}

Thoughts, comments, criticisms?


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)