Return-Path: X-Original-To: apmail-aries-dev-archive@www.apache.org Delivered-To: apmail-aries-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2F5F21821C for ; Fri, 28 Aug 2015 11:31:46 +0000 (UTC) Received: (qmail 12742 invoked by uid 500); 28 Aug 2015 11:31:46 -0000 Delivered-To: apmail-aries-dev-archive@aries.apache.org Received: (qmail 12705 invoked by uid 500); 28 Aug 2015 11:31:46 -0000 Mailing-List: contact dev-help@aries.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@aries.apache.org Delivered-To: mailing list dev@aries.apache.org Received: (qmail 12686 invoked by uid 99); 28 Aug 2015 11:31:46 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Aug 2015 11:31:45 +0000 Date: Fri, 28 Aug 2015 11:31:45 +0000 (UTC) From: =?utf-8?Q?Cristiano_Gavi=C3=A3o_=28JIRA=29?= To: dev@aries.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ARIES-1387) Make Subsystem header items order reproducible MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ARIES-1387?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1471= 8375#comment-14718375 ]=20 Cristiano Gavi=C3=A3o commented on ARIES-1387: ----------------------------------------- Hi John, last night I've worked on the Header classes.=20 Tonight I will deal with the clause classes and in the weekend I will creat= e some unit tests for them.=20 > Make Subsystem header items order reproducible > ---------------------------------------------- > > Key: ARIES-1387 > URL: https://issues.apache.org/jira/browse/ARIES-1387 > Project: Aries > Issue Type: Improvement > Components: Subsystem > Reporter: Cristiano Gavi=C3=A3o > > Currently the org.apache.aries.subsystem.core.archive.SubsystemContentHea= der class (line 210) and other headers classes uses a HashSet in order to h= old its clauses. > HashSet doesn't ensure the order of its items and then its impossible to = have a reproducible build of any manifest file. As the SubsystemManifest cl= ass doesn't provide a equals() method, we can't compare a generated manifes= t file with any template in a test, it will fail. > The propose it to change the used HashSet for the LinkedHashSet class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)