aries-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Cristiano Gavião (JIRA) <>
Subject [jira] [Commented] (ARIES-1387) Make Subsystem header items order reproducible
Date Fri, 28 Aug 2015 12:58:45 GMT


Cristiano Gavião commented on ARIES-1387:

Hi John, one doubt.
It is in the spec that Clause classes *must* be totally immutable ? 

I'm asking because almost all clauses have same fields and have many same methods. Perhaps
extending them from an abstract clause class and do not expose set methods for common fields
wouldn't be enough instead to have all that duplicated code? 

> Make Subsystem header items order reproducible
> ----------------------------------------------
>                 Key: ARIES-1387
>                 URL:
>             Project: Aries
>          Issue Type: Improvement
>          Components: Subsystem
>            Reporter: Cristiano Gavião
> Currently the org.apache.aries.subsystem.core.archive.SubsystemContentHeader class (line
210) and other headers classes uses a HashSet in order to hold its clauses.
> HashSet doesn't ensure the order of its items and then its impossible to have a reproducible
build of any manifest file. As the SubsystemManifest class doesn't provide a equals() method,
we can't compare a generated manifest file with any template in a test, it will fail.
> The propose it to change the used HashSet for the LinkedHashSet class.

This message was sent by Atlassian JIRA

View raw message