Return-Path: X-Original-To: apmail-aries-dev-archive@www.apache.org Delivered-To: apmail-aries-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 680EC17F2E for ; Thu, 9 Oct 2014 07:24:34 +0000 (UTC) Received: (qmail 12598 invoked by uid 500); 9 Oct 2014 07:24:34 -0000 Delivered-To: apmail-aries-dev-archive@aries.apache.org Received: (qmail 12552 invoked by uid 500); 9 Oct 2014 07:24:34 -0000 Mailing-List: contact dev-help@aries.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@aries.apache.org Delivered-To: mailing list dev@aries.apache.org Received: (qmail 12540 invoked by uid 99); 9 Oct 2014 07:24:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Oct 2014 07:24:34 +0000 Date: Thu, 9 Oct 2014 07:24:33 +0000 (UTC) From: "Christian Schneider (JIRA)" To: dev@aries.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ARIES-1247) EntityManagerFactoryManager: remove the try of creation of EntityManagerFactories from Bundle.RESOLVED event MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ARIES-1247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14164858#comment-14164858 ] Christian Schneider commented on ARIES-1247: -------------------------------------------- Not sure what you refer to. The aries jpa extender only creates the EMF as a service. So it is the job of the user injection system like blueprint or DS to react on the EMF service and instantiate the beans. > EntityManagerFactoryManager: remove the try of creation of EntityManagerFactories from Bundle.RESOLVED event > ------------------------------------------------------------------------------------------------------------ > > Key: ARIES-1247 > URL: https://issues.apache.org/jira/browse/ARIES-1247 > Project: Aries > Issue Type: Improvement > Components: JPA > Affects Versions: jpa-container-context-1.0.3 > Reporter: Andrei Shakirin > Assignee: Christian Schneider > Attachments: ARIES-jpa-EntityManagerFactoryManager.patch > > > EntityManagerFactoryManager: > As it was already mentioned in ARIES-1160, I do not see any benefit for trying to create EntityManagerFactories on Bundle.RESOLVED event. > On time of Bundle.RESOLVED the bundle context is still not initialized and trying of creation EntityManagerFactory will likely failed (Hibernate and EclipseLink implementations are failed by lookup of DataSource service). > It only confuses user with a stack trace. > The EntityManagerFactories will be created a tick later on Bundle.ACTIVE event by calling registerEntityManagerFactories() method. > Patch is attached. -- This message was sent by Atlassian JIRA (v6.3.4#6332)