Mailing-List: contact dev-help@aries.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@aries.apache.org
Received-SPF: pass (athena.apache.org: local policy includes SPF record at
 spf.trusted-forwarder.org)
Content-Type: text/plain; charset=windows-1252
Mime-Version: 1.0 (Mac OS X Mail 7.2 \(1874\))
Subject: Re: Accepting pull requests for Aries from Github
From: Daniel Kulp <dkulp@apache.org>
In-Reply-To: 
 <CAMit8Spx2LH0HXDBMew2eY3SA=V5rdS6J8LYPQkc6aasyKb7JA@mail.gmail.com>
Date: Thu, 27 Mar 2014 15:31:27 -0400
Content-Transfer-Encoding: quoted-printable
Message-Id: <2FBB8F3E-17F8-457C-98AC-A3F2BECEC0F1@apache.org>
References: 
 <CAMit8Spx2LH0HXDBMew2eY3SA=V5rdS6J8LYPQkc6aasyKb7JA@mail.gmail.com>
To: dev@aries.apache.org,
 davidb@apache.org


On Mar 27, 2014, at 8:05 AM, davidb@apache.org wrote:

> Hi all,
>=20
> I noticed that there are a few pull requests on Aries at github [1].
> I was wondering, can we just apply these, or must they be physically
> attached to JIRA issues to correctly follow IP rules?
> I noticed that e.g. [2] does mention the pull request in the =
comments...
>=20
> Just wondering what the process should be=85

Pulling the pull requests directly is fine.  Many projects have started =
preferring that.

When you do, it=92s sometimes best to amend/edit the commit log to =
include something like

=93This closes #2=94=20

so the pull request will close automatically when you commit.

Dan


>=20
> Cheers,
>=20
> David
>=20
> [1] https://github.com/apache/aries/pulls
> [2] https://issues.apache.org/jira/browse/ARIES-1164

--=20
Daniel Kulp
dkulp@apache.org - http://dankulp.com/blog
Talend Community Coder - http://coders.talend.com