Return-Path: X-Original-To: apmail-aries-dev-archive@www.apache.org Delivered-To: apmail-aries-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 20D9810F90 for ; Tue, 12 Nov 2013 17:56:19 +0000 (UTC) Received: (qmail 936 invoked by uid 500); 12 Nov 2013 17:56:17 -0000 Delivered-To: apmail-aries-dev-archive@aries.apache.org Received: (qmail 841 invoked by uid 500); 12 Nov 2013 17:56:17 -0000 Mailing-List: contact dev-help@aries.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@aries.apache.org Delivered-To: mailing list dev@aries.apache.org Received: (qmail 666 invoked by uid 99); 12 Nov 2013 17:56:15 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Nov 2013 17:56:15 +0000 X-ASF-Spam-Status: No, hits=2.2 required=5.0 tests=HTML_MESSAGE,MSGID_FROM_MTA_HEADER,RCVD_IN_DNSWL_NONE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of timothyjward@hotmail.com designates 65.55.116.110 as permitted sender) Received: from [65.55.116.110] (HELO blu0-omc3-s35.blu0.hotmail.com) (65.55.116.110) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Nov 2013 17:56:06 +0000 Received: from BLU0-SMTP140 ([65.55.116.73]) by blu0-omc3-s35.blu0.hotmail.com with Microsoft SMTPSVC(6.0.3790.4675); Tue, 12 Nov 2013 09:55:45 -0800 X-TMN: [V1IE5T+eBtE86Um1uV4RKIj50FcVn9vD] X-Originating-Email: [timothyjward@hotmail.com] Message-ID: Received: from [192.168.1.69] ([87.115.245.12]) by BLU0-SMTP140.phx.gbl over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Tue, 12 Nov 2013 09:55:41 -0800 From: Timothy Ward Content-Type: multipart/alternative; boundary="Apple-Mail=_00D5E00E-AC79-4635-9F58-68C983A7A8A1" MIME-Version: 1.0 (Mac OS X Mail 6.6 \(1510\)) Subject: Re: svn commit: r1541021 - in /aries/trunk/jpa: jpa-api/pom.xml jpa-container-context/pom.xml jpa-container/pom.xml Date: Tue, 12 Nov 2013 17:55:48 +0000 References: <20131112120704.B9CFE23889E3@eris.apache.org> To: dev@aries.apache.org In-Reply-To: <20131112120704.B9CFE23889E3@eris.apache.org> X-Mailer: Apple Mail (2.1510) X-OriginalArrivalTime: 12 Nov 2013 17:55:42.0231 (UTC) FILETIME=[67762270:01CEDFD0] Sender: X-Virus-Checked: Checked by ClamAV on apache.org --Apple-Mail=_00D5E00E-AC79-4635-9F58-68C983A7A8A1 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="us-ascii" Mark, could you please revert this commit? I have outlined the issues with the proposed solution in the JIRA item = (https://issues.apache.org/jira/browse/ARIES-1134) where the patch was = submitted. In brief there are two problems: The version ranges are wrong. o.a.aries.jpa.container and = o.a.aries.jpa.container.context are API providers, and so need a = provider version range, not a consumer client range. The implementations haven't been updated to support the new API methods, = which means that the bundles are broken when used with the JPA 2.1 API. Regards, Tim On 12 Nov 2013, at 12:07, mnuttall@apache.org wrote: > Author: mnuttall > Date: Tue Nov 12 12:07:04 2013 > New Revision: 1541021 >=20 > URL: http://svn.apache.org/r1541021 > Log: > Aries-1134: Enable JPA 2.1 API and correct inconsistent versioning >=20 > Modified: > aries/trunk/jpa/jpa-api/pom.xml > aries/trunk/jpa/jpa-container-context/pom.xml > aries/trunk/jpa/jpa-container/pom.xml >=20 > Modified: aries/trunk/jpa/jpa-api/pom.xml > URL: = http://svn.apache.org/viewvc/aries/trunk/jpa/jpa-api/pom.xml?rev=3D1541021= &r1=3D1541020&r2=3D1541021&view=3Ddiff > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- aries/trunk/jpa/jpa-api/pom.xml (original) > +++ aries/trunk/jpa/jpa-api/pom.xml Tue Nov 12 12:07:04 2013 > @@ -46,8 +46,8 @@ > org.apache.aries.jpa.container.context > > > - javax.persistence;version=3D"[1.0.0,2.1.0)", > - javax.persistence.spi;version=3D"[1.0.0,2.1.0)", > + javax.persistence;version=3D"[1.0.0,3.0.0)", > + javax.persistence.spi;version=3D"[1.0.0,3.0.0)", > org.osgi.framework;version=3D"[1.5.0,2.0.0)" > > >=20 > Modified: aries/trunk/jpa/jpa-container-context/pom.xml > URL: = http://svn.apache.org/viewvc/aries/trunk/jpa/jpa-container-context/pom.xml= ?rev=3D1541021&r1=3D1541020&r2=3D1541021&view=3Ddiff > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- aries/trunk/jpa/jpa-container-context/pom.xml (original) > +++ aries/trunk/jpa/jpa-container-context/pom.xml Tue Nov 12 12:07:04 = 2013 > @@ -43,9 +43,9 @@ >=20 > > > - javax.persistence;version=3D"[1.0.0,2.1.0)", > - = javax.persistence.criteria;version=3D"[1.1.0,2.1.0)";resolution:=3Doptiona= l, > - = javax.persistence.metamodel;version=3D"[1.1.0,2.1.0)";resolution:=3Doption= al, > + javax.persistence;version=3D"[1.0.0,3.0.0)", > + = javax.persistence.criteria;version=3D"[1.1.0,3.0.0)";resolution:=3Doptiona= l, > + = javax.persistence.metamodel;version=3D"[1.1.0,3.0.0)";resolution:=3Doption= al, > org.apache.aries.jpa.container.context;provide:=3Dtrue, > = org.apache.aries.quiesce.manager;provide:=3Dtrue;resolution:=3Doptional, > = org.apache.aries.quiesce.participant;provide:=3Dtrue;resolution:=3Doptiona= l, >=20 > Modified: aries/trunk/jpa/jpa-container/pom.xml > URL: = http://svn.apache.org/viewvc/aries/trunk/jpa/jpa-container/pom.xml?rev=3D1= 541021&r1=3D1541020&r2=3D1541021&view=3Ddiff > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- aries/trunk/jpa/jpa-container/pom.xml (original) > +++ aries/trunk/jpa/jpa-container/pom.xml Tue Nov 12 12:07:04 2013 > @@ -42,10 +42,10 @@ >=20 > > > - javax.persistence;version=3D"[1.0.0,2.1.0)", > - javax.persistence.spi;version=3D"[1.0.0,2.1.0)", > - = javax.persistence.criteria;version=3D"[1.1.0,2.1.0)";resolution:=3Doptiona= l, > - = javax.persistence.metamodel;version=3D"[1.1.0,2.1.0)";resolution:=3Doption= al, > + javax.persistence;version=3D"[1.0.0,3.0.0)", > + javax.persistence.spi;version=3D"[1.0.0,3.0.0)", > + = javax.persistence.criteria;version=3D"[1.1.0,3.0.0)";resolution:=3Doptiona= l, > + = javax.persistence.metamodel;version=3D"[1.1.0,3.0.0)";resolution:=3Doption= al, > !javax.transaction, > org.apache.aries.jpa.container*;provide:=3Dtrue, > = org.apache.aries.quiesce.manager;provide:=3Dtrue;resolution:=3Doptional, >=20 >=20 --Apple-Mail=_00D5E00E-AC79-4635-9F58-68C983A7A8A1--