Return-Path: X-Original-To: apmail-aries-dev-archive@www.apache.org Delivered-To: apmail-aries-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EC9C71017B for ; Thu, 25 Apr 2013 16:13:00 +0000 (UTC) Received: (qmail 10385 invoked by uid 500); 25 Apr 2013 16:13:00 -0000 Delivered-To: apmail-aries-dev-archive@aries.apache.org Received: (qmail 10216 invoked by uid 500); 25 Apr 2013 16:13:00 -0000 Mailing-List: contact dev-help@aries.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@aries.apache.org Delivered-To: mailing list dev@aries.apache.org Received: (qmail 10208 invoked by uid 99); 25 Apr 2013 16:13:00 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Apr 2013 16:13:00 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of jpjhughes@gmail.com designates 74.125.82.176 as permitted sender) Received: from [74.125.82.176] (HELO mail-we0-f176.google.com) (74.125.82.176) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Apr 2013 16:12:55 +0000 Received: by mail-we0-f176.google.com with SMTP id s10so2704785wey.21 for ; Thu, 25 Apr 2013 09:12:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:mime-version:in-reply-to:references:from:date:message-id :subject:to:content-type; bh=5C6Sn0X6E3yTm6VwBxe22g3PybNrSvpcxAZaC3+/zpE=; b=yRPQLAqtML/AStJLw6zk3ow/wehE1m2z3u6aFhjK19l+ZYLBtSoXrbppXWPIi7nvH+ wyu5DBPL9QUASo/0iD1zrY9jfVBSjqF91hO7O+ZJibOr5qF8JDcFRokoMd1hvyLvV1+Q rpiH91Npso6mf1cVMC0tZPnxGvwstdE1wTbTW/R01rCauBlT2l2pqZtUucYJQOIJDf1y 4h5/hxVrbBuMl7B6cyHFcZXifwzUzvvD4AYnS53g69873GGF4a4FUimXIUbOhOxttA97 Yij1kKblQkq73meUY7Z+LnE0B57+6BMkZXYrLXxgpwjmHsGyAF4dnOKS9YINYA2b3K5L ptSw== X-Received: by 10.180.83.199 with SMTP id s7mr52211350wiy.19.1366906353670; Thu, 25 Apr 2013 09:12:33 -0700 (PDT) MIME-Version: 1.0 Received: by 10.194.137.174 with HTTP; Thu, 25 Apr 2013 09:12:13 -0700 (PDT) In-Reply-To: References: <0BE54E34-D0C9-49CC-8CF5-00064055A2A4@gmail.com> <31C32FEE-30A0-45D3-9DE8-2CD06FF1B877@yahoo.com> From: Jeremy Hughes Date: Thu, 25 Apr 2013 17:12:13 +0100 Message-ID: Subject: Re: Generating source for uber bundles To: dev@aries.apache.org Content-Type: multipart/alternative; boundary=14dae9cc973ca6de2804db31af5e X-Virus-Checked: Checked by ClamAV on apache.org --14dae9cc973ca6de2804db31af5e Content-Type: text/plain; charset=ISO-8859-1 +1 .. if it helps some people and doesn't hurt the rest then it must be good. On 25 April 2013 17:04, John W Ross wrote: > > I agree, and, based on Stuart's response to your other note, it seems like > he's at least okay with it. > > The infrastructure for generating the sources.jar is already there as long > as you specify the deploy profile when running mvn release:prepare/perform. > > Unless there are any objections, I'll redo the subsystem-bundle release > with a sources.jar containing the complete source, but a source-release.zip > representing what was actually there when it was built (which is how it is > now). > > John > > > > > Re: Generating source for uber bundles > > > > As I mentioned in another thread, the source-release is supposed to > > be an accurate representation of how you built the project. Since > > this one is built by aggregating other jars, it should NOT include > > the source of those jars, it should be what the maven plugin comes > > up with unassisted. > > > > The non-mandatory for-the-convenience-of-debugging source.jar can > > have the aggregated source of the aggregated jars, but you can also > > leave it out. > > > > thanks > > david jencks > > On Apr 25, 2013, at 6:55 AM, John W Ross wrote: > > > > > > > > The subsystem pom, following the pattern of other projects with uber > > > bundles such as application and blueprint, was already configured to > > > aggregate the source. However, one must specify the "deploy" profile > when > > > generating the release artifacts in order for the aggregation to occur. > > > > > > Specifying the "deploy" profile will get the source in the sources jar > > > (e.g., org.apache.aries.subsystem-1.0.0-SNAPSHOT-sources.jar) but not > in > > > the source-release zip (e.g., > > > org.apache.aries.subsystem-1.0.0-SNAPSHOT-source-release.zip). > > > > > > Any advice on how to get the aggregated source in the source-release > zip > > > file? > > > > > > John > > > > > >> > > >> Re: [VOTE] subsystem-bundle 1.0.0 > > >> > > >> Yep, they're empty. Nice catch. I wonder if there's a way to put some > > > sort > > >> of sanity check into the verify script for this. > > >> > > >> Anyway, I'll have to figure out how to fix this. Presumably this means > > >> dropping the current staging repository, deleting the svn tag, and > > > starting > > >> over. Sorry! > > >> > > >> John > > >> > > >>> > > >>> Re: [VOTE] subsystem-bundle 1.0.0 > > >>> > > >>> On 18 Apr 2013, at 10:55, John W Ross wrote: > > >>> > > >>>> This is a vote for the release of subsystem-bundle 1.0.0, an uber > > >> bundle > > >>>> containing subsystem-api 1.0.0 and subsystem-core 1.0.0. > > >>>> > > >>>> Staging Area: > > >>>> > > > https://repository.apache.org/content/repositories/orgapachearies-117/ > > >>>> > > >>>> Tags: > > >>>> > > >> > http://svn.apache.org/viewvc/aries/tags/org.apache.aries.subsystem-1.0.0/ > > >>>> > > >>>> This vote will remain open for at least 72 hours. > > >>> > > >>> I can't see any sources in either org.apache.aries.subsystem-1.0.0- > > >>> sources.jar or org.apache.aries.subsystem-1.0.0-source-release.zip > > >>> > > >>> It's important that the release contains sources so people can build > > >>> it themselves: http://www.apache.org/dev/release.html#what-must- > > >>> every-release-contain > > >>> > > >>> Note that it is possible to aggregate the source for "uber-bundles" > > >>> by using the maven-dependency-plugin to unpack the sources of all > > >>> bundled dependencies. > > >>> > > >>>> John > > > --14dae9cc973ca6de2804db31af5e--