Mailing-List: contact dev-help@aries.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@aries.apache.org
Received-SPF: pass (nike.apache.org: domain of fmeschbe@adobe.com designates
 64.18.1.31 as permitted sender)
From: Felix Meschberger <fmeschbe@adobe.com>
To: "dev@aries.apache.org" <dev@aries.apache.org>
Date: Fri, 2 Mar 2012 10:24:24 +0000
Subject: Re: JNDI log messages
Thread-Topic: JNDI log messages
Thread-Index: Acz4XkHIJ3UIFxIqQsqnW5VygMbKngAAGGzY
Message-ID: <6afuov0xc65prl24hldx2iri.1330683860472@email.android.com>
Accept-Language: de-DE, en-US
Content-Language: de-DE
acceptlanguage: de-DE, en-US
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

When you run embedded in an app server the factory tends to be set ...
Regards
Felix

Guillaume Nodet <gnodet@gmail.com> schrieb:


Isn't that a real problem if the factory is already set ? Or is that a
valid use case ?

On Fri, Mar 2, 2012 at 10:52, David Bosschaert
<david.bosschaert@gmail.com>wrote:

> Another email about logging ...
>
> During the integration of the Aries JNDI component in our project we
> hit an issue with the log messages emitted from
>
> https://svn.apache.org/repos/asf/aries/trunk/jndi/jndi-core/src/main/java=
/org/apache/aries/jndi/startup/Activator.java
>
> Specifically the following block (there is a second block just like
> this one too):
>
> try {
>  OSGiInitialContextFactoryBuilder builder =3D new
> OSGiInitialContextFactoryBuilder();
>  NamingManager.setInitialContextFactoryBuilder(builder);
>  icfBuilder =3D builder;
> } catch (NamingException e) {
>  LOGGER.info(Utils.MESSAGES.getMessage("unable.to.set.static.ICFB"), e);
> } catch (IllegalStateException e) {
>
>  LOGGER.info(Utils.MESSAGES.getMessage("unable.to.set.static.ICFB.already=
.exists",
> getClassName(InitialContextFactoryBuilder.class)), e);
> }
>
> In our case the InitialContextFactoryBuilder is already set, so there
> will be an IllegalStateException, but this is totally harmless in our
> case. It's fine to log an INFO message, but we don't want the
> exception to appear at this level, as that gets people worried,
> therefore, would it be acceptable to change the log message to
> something like this?
>
>
>  LOGGER.info(Utils.MESSAGES.getMessage("unable.to.set.static.ICFB.already=
.exists",
> getClassName(InitialContextFactoryBuilder.class)));
>
>  LOGGER.debug(Utils.MESSAGES.getMessage("unable.to.set.static.ICFB.alread=
y.exists",
> getClassName(InitialContextFactoryBuilder.class)), e);
>
> So that the message is still logged at debug level but the exception
> only appear at Debug level?
>
> Thanks,
>
> David
>


--
------------------------
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
FuseSource, Integration everywhere
http://fusesource.com