Return-Path: X-Original-To: apmail-aries-dev-archive@www.apache.org Delivered-To: apmail-aries-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 18E109AF7 for ; Thu, 10 Nov 2011 21:38:17 +0000 (UTC) Received: (qmail 43092 invoked by uid 500); 10 Nov 2011 21:38:17 -0000 Delivered-To: apmail-aries-dev-archive@aries.apache.org Received: (qmail 43050 invoked by uid 500); 10 Nov 2011 21:38:16 -0000 Mailing-List: contact dev-help@aries.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@aries.apache.org Delivered-To: mailing list dev@aries.apache.org Received: (qmail 43042 invoked by uid 99); 10 Nov 2011 21:38:16 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Nov 2011 21:38:16 +0000 X-ASF-Spam-Status: No, hits=0.7 required=5.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [64.85.173.253] (HELO server.dankulp.com) (64.85.173.253) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Nov 2011 21:38:09 +0000 Received: by server.dankulp.com (Postfix, from userid 5000) id 14C70184287; Thu, 10 Nov 2011 16:37:47 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on server.dankulp.com X-Spam-Level: X-Msg-File: /tmp/mailfilter-dev@aries.apache.org.J8oHUhlEMg Received: from dilbert.dankulp.com (unknown [208.181.48.95]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by server.dankulp.com (Postfix) with ESMTPSA id 6CB3C184287; Thu, 10 Nov 2011 16:37:46 -0500 (EST) From: Daniel Kulp To: dev@aries.apache.org Cc: Jean-Baptiste =?ISO-8859-1?Q?Onofr=E9?= Subject: Re: Problems deploying blueprint-cm ? Date: Thu, 10 Nov 2011 16:37:45 -0500 Message-ID: <4107260.0PzFjXWLdZ@dilbert.dankulp.com> User-Agent: KMail/4.7.3 (Linux/3.0.1; KDE/4.7.3; x86_64; ; ) In-Reply-To: <4EBC3B86.1000504@nanthrax.net> References: <4EBC3B86.1000504@nanthrax.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-Virus-Checked: Checked by ClamAV on apache.org X-Old-Spam-Status: No, score=-102.9 required=3.0 tests=ALL_TRUSTED,BAYES_00, SHORTCIRCUIT shortcircuit=ham autolearn=disabled version=3.3.1 On Thursday, November 10, 2011 10:00:54 PM Jean-Baptiste Onofr=E9 wrote= : > Hi, >=20 > it could be helpful for the Karaf update. >=20 > AFAIK, Dan would like to include some fixes. It could be a good oppor= tunity. I just put a 1 line change to fix PART of ARIES-626. I need to star= t a=20 discuss about the rest of it and likely won't get to fix it for 0.4.1. = =20 There is always 0.4.2. :-) Dan >=20 > Regards > JB >=20 > On 11/10/2011 09:58 PM, Jeremy Hughes wrote: > > On 10 November 2011 17:11, Timothy Ward w= rote: > >> Can you remeber which artifacts will be affected? I think > >> blueprint-core, blueprint-bundle and blueprint-itests. I can't > >> remember > >> if one of the proxy bundles had a problem in 047 too. > >>=20 > >> I suppose we can check the vote history to find out. > >=20 > > Three bundles changed in attempt #3 they were from the blueprint-cm= > > blueprint-core and blueprint-bundle modules. The blueprint-cm and > > blueprint-bundle modules are dated 28th Oct, just before I sent the= > > attempt #3 vote email. The blueprint-core module artifacts are date= d > > 25th Oct which corresponds to the attempt #1 vote. > >=20 > > Are we good to release (0.4.1) what's in trunk for blueprint-core a= nd > > then of course release blueprint-bundle to make sure blueprint-bund= le > > contains the correct blueprint-core ? Or are there some fixes neede= d > > before we do that? > >=20 > >> Regards, > >>=20 > >> Tim > >>=20 > >>> From: hughesj@apache.org > >>> Date: Thu, 10 Nov 2011 16:45:34 +0000 > >>> Subject: Re: Problems deploying blueprint-cm ? > >>> To: dev@aries.apache.org > >>>=20 > >>> On 10 November 2011 16:29, Jeremy Hughes wro= te: > >>>> On 10 November 2011 15:23, Timothy Ward= =20 wrote: > >>>>>> Date: Thu, 10 Nov 2011 05:40:58 -0800 > >>>>>> Subject: Re: Problems deploying blueprint-cm ? > >>>>>> From: gnodet@gmail.com > >>>>>> To: dev@aries.apache.org > >>>>>>=20 > >>>>>> On Thu, Nov 10, 2011 at 05:32, Timothy Ward =20 wrote: > >>>>>>> That's odd, I don't have any uncommitted changes, but my > >>>>>>> blueprint-core bundle has the following export package > >>>>>>> list, which does include the blueprint utils: > >>>>>>>=20 > >>>>>>>=20 > >>>>>>> Export-Package: > >>>>>>> org.apache.aries.blueprint;version=3D"0.4";uses:=3D"org.os>>>= >>>>=20 > >>>>>>> gi.service.blueprint.reflect,org.osgi.framework,org.w3c. > >>>>>>> dom",org.apac > >>>>>>> he.aries.blueprint.mutable;version=3D"0.3.2";uses:=3D"org.o= > >>>>>>> sgi.service.bl > >>>>>>> ueprint.reflect,org.apache.aries.blueprint,org.osgi.fra > >>>>>>> mework",org.ap > >>>>>>> ache.aries.blueprint.ext.evaluator;version=3D"0.3.2",org. > >>>>>>> apache.aries.b > >>>>>>> lueprint.services;version=3D"0.4";uses:=3D"org.osgi.framewo= > >>>>>>> rk,org.apache. > >>>>>>> aries.blueprint,org.osgi.service.blueprint.container",o > >>>>>>> rg.apache.arie > >>>>>>> s.blueprint.utils;version=3D"0.4.0";uses:=3D"org.osgi.frame= > >>>>>>> work,org.apach > >>>>>>> e.aries.blueprint,org.osgi.service.blueprint.reflect,or > >>>>>>> g.apache.aries > >>>>>>> .blueprint.mutable,org.osgi.service.blueprint.container > >>>>>>> ,org.slf4j,org > >>>>>>> .apache.aries.blueprint.ext.evaluator,org.apache.aries. > >>>>>>> blueprint.serv > >>>>>>> ices",org.osgi.service.blueprint;version=3D"1.0.0" > >>>>>>=20 > >>>>>> For some reason, that does not seem to be the case with the > >>>>>> released > >>>>>> artifact.. Not sure what happened. > >>>>>=20 > >>>>> I see what you mean - the artifact in the maven repository > >>>>> doesn't match the source from the oct2011 branch, or the 0.4 > >>>>> tag for that bundle... > >>>>>=20 > >>>>> We may need Jeremy's input here. It's possible that the wrong > >>>>> thing got promoted, or maybe I don't fully understand the > >>>>> release process!>>>>=20 > >>>> Oh dear. I released the two staging repo's voted on, so I don't > >>>> know > >>>> what's happened here. I'll look into what's in the Apache releas= es > >>>> repo. > >>>=20 > >>> This is incredibly frustrating. I can only imagine the > >>> blueprint-core > >>> release that I deleted from the 047 staging repo was published by= > >>> Nexus instead of the one in the 116 staging repo. I've checked my= > >>> blueprint/blueprint-core/target/checkout/target/org.apache.aries.= blu > >>> eprint.core-0.4.jar and it is dated 28th Oct as are the ones in m= y > >>> local .m2 repository, whereas the one in the releases repo is dat= ed > >>> 25th Oct. So I really don't know what has happened here. Since th= e > >>> artifacts will have likely been mirrored the only sensible thing = is > >>> for me to run a 0.4.1 release of the affected artifacts. > >>>=20 > >>>>>>> I don't see the core bundle exporting either of the > >>>>>>> blueprint API packages > >>>>>>> (org.osgi.service.blueprint.container or > >>>>>>> org.osgi.service.blueprint.reflect), but it does export the > >>>>>>> empty package org.osgi.service.blueprint, which I think is > >>>>>>> spec mandated to come from the blueprint implementation. > >>>>>>> I'll check that one to be sure. > >>>>>>=20 > >>>>>> Yep, that's right. I was fooled by the fact that it used > >>>>>> another api I deployed earlier. Sorry about that. > >>>>>> Note that the spec also mandates that the blueprint extender > >>>>>> provides (exporting and not importing) its own api so that > >>>>>> multiple extenders can't be wired to the same api, as that's > >>>>>> what is used to make sure multiple extenders can coexists > >>>>>> peacefully. Given the extender checks for compatibilty, if > >>>>>> each extender has its own api, and provided that blueprint > >>>>>> bundles import the api as mandated by the spec, there's no > >>>>>> inconsistency, even if you can't easily choose which extender > >>>>>> is used for a given bundle.>>>>>>=20 > >>>>>>> As for property placeholder support, my understanding (based > >>>>>>> on the cm implementation) was that people who wanted > >>>>>>> property placeholders either used or subclassed > >>>>>>> PropertyPlaceHolder (which is currently still possible), > >>>>>>> and that the AbstractPropertyPlaceHolder was for internal > >>>>>>> use by blueprint. I could be wrong with my understanding of > >>>>>>> the API here, and if so I have no problem working to > >>>>>>> improve/correct it. > >>>>>>=20 > >>>>>> The PropertyPlaceHolder can be used in some cases, but I have > >>>>>> a custom namespace which actually use the > >>>>>> AbstractPropertyPlaceHolder, where most of the processing is > >>>>>> done. > >>>>>>=20 > >>>>>>> My main aim with the packaging changes is to make sure that > >>>>>>> the blueprint bundles use good OSGi practice and therefore > >>>>>>> define a proper API. Previous versions of blueprint have > >>>>>>> exposed every package, including classes that I definitely > >>>>>>> wouldn't expect to be API (for example the recipes or the > >>>>>>> internal parser implementation). I do want it to be > >>>>>>> possible to write functional namespace handlers, but I > >>>>>>> don't expect them to be able to change the internal > >>>>>>> behaviour of blueprint (for example how beans are > >>>>>>> instantiated, or injected with dependencies) unless they > >>>>>>> are either the ext namespace (which is internal and a bit > >>>>>>> special) or built as fragments that add to the core > >>>>>>> blueprint function. > >>>>>>>=20 > >>>>>>> When making this change I was careful to make sure that any > >>>>>>> existing namespace handlers I knew of (JPA, TX, CM) were > >>>>>>> able to keep working. This did require some changes to the > >>>>>>> CM bundle, which had numerous (and some unnecessary) > >>>>>>> couplings to the blueprint internals, but not to the > >>>>>>> others. Is there something else from blueprint that we > >>>>>>> should make part of the API, or perhaps expose as a > >>>>>>> service, to help other namespaces? > >>>>>>=20 > >>>>>> I'm not aware of anything else for now beyond > >>>>>> the AbstractPropertyPlaceHolder. > >>>>>>=20 > >>>>>>> Regards, > >>>>>>>=20 > >>>>>>> Tim > >>>>>>>=20 > >>>>>>>> Date: Thu, 10 Nov 2011 03:26:39 -0800 > >>>>>>>> Subject: Re: Problems deploying blueprint-cm ? > >>>>>>>> From: gnodet@gmail.com > >>>>>>>> To: dev@aries.apache.org > >>>>>>>>=20 > >>>>>>>> Actually, it's not exported by blueprint-core either even > >>>>>>>> if the pom says so for some reason. Here's the list of > >>>>>>>> exported packages by>>>>>>>=20 > >>>>>>> blueprint-core > >>>>>>>=20 > >>>>>>>> from its manifest: > >>>>>>>>=20 > >>>>>>>> Export-Package: > >>>>>>>> org.apache.aries.blueprint;version=3D"0.4";uses:=3D"org.os>>= >>>>>>=20 > >>>>>>>> gi.service.blueprint.reflect,org.osgi.framework,org.w3 > >>>>>>>> c.dom",org.apac > >>>>>>>> he.aries.blueprint.mutable;version=3D"0.3.2";uses:=3D"org > >>>>>>>> .osgi.service.bl > >>>>>>>> ueprint.reflect,org.apache.aries.blueprint,org.osgi.f > >>>>>>>> ramework",org.ap > >>>>>>>> ache.aries.blueprint.ext.evaluator;version=3D"0.3.2",or > >>>>>>>> g.apache.aries.b > >>>>>>>> lueprint.services;version=3D"0.4";uses:=3D"org.osgi.frame > >>>>>>>> work,org.apache. > >>>>>>>> aries.blueprint,org.osgi.service.blueprint.container" > >>>>>>>> ,org.osgi.servic e.blueprint;version=3D"1.0.0" > >>>>>>>>=20 > >>>>>>>> Also blueprint-core seems to export blueprint-api (I > >>>>>>>> thought only the>>>>>>>=20 > >>>>>>> full > >>>>>>>=20 > >>>>>>>> blueprint bundle was supposed to aggregate those). > >>>>>>>> So given the util package isn't exported at all, > >>>>>>>> blueprint-core + > >>>>>>>> blueprint-cm seems unusable to me. > >>>>>>>>=20 > >>>>>>>> As for the util package itself, exporting it is actually > >>>>>>>> not sufficient.>>>>>>>>=20 > >>>>>>>> The PlaceholderUtils is using the > >>>>>>>> AbstractPropertyPlaceholder to check>>>>>>>=20 > >>>>>>> the > >>>>>>>=20 > >>>>>>>> consistency of placeholders, but that class isn't exported > >>>>>>>> anymore, so downstream namespace handlers can't use it. =20 > >>>>>>>> Even if we fix>>>>>>>=20 > >>>>>>> blueprint-core > >>>>>>>=20 > >>>>>>>> to export the utils package, that class need to be made > >>>>>>>> available somehow so that it can be extended, so I > >>>>>>>> suppose it'd have to be moved to utils>>>>>>>=20 > >>>>>>> too. > >>>>>>>=20 > >>>>>>>> On Thu, Nov 10, 2011 at 03:17, Timothy > >>>>>>>> Ward>>>>>>>=20 > >>>>>>> wrote: > >>>>>>>>> Hi Guillaume, > >>>>>>>>>=20 > >>>>>>>>> org.apache.aries.blueprint.utils is exported by the > >>>>>>>>> blueprint core>>>>>>>=20 > >>>>>>> bundle > >>>>>>>=20 > >>>>>>>>> at version 0.4. As you identified in another thread it > >>>>>>>>> should also be>>>>>>>=20 > >>>>>>> being > >>>>>>>=20 > >>>>>>>>> exported by the blueprint-bundle, but isn't. As for > >>>>>>>>> deploying > >>>>>>>=20 > >>>>>>> blueprint-cm, > >>>>>>>=20 > >>>>>>>>> I believe it's possible if you install blueprint-api and > >>>>>>>=20 > >>>>>>> blueprint-core, > >>>>>>>=20 > >>>>>>>>> but as another approach, doesn't the blueprint-bundle > >>>>>>>>> contain the > >>>>>>>>> blueprint-cm function by default? I think that should > >>>>>>>>> deploy fine as>>>>>>>=20 > >>>>>>> it's > >>>>>>>=20 > >>>>>>>>> what's used in the CM itests. > >>>>>>>>>=20 > >>>>>>>>> I hope this is helpful. > >>>>>>>>>=20 > >>>>>>>>> Tim > >>>>>>>>>=20 > >>>>>>>>>> Date: Wed, 9 Nov 2011 15:10:44 -0800 > >>>>>>>>>> Subject: Problems deploying blueprint-cm ? > >>>>>>>>>> From: gnodet@gmail.com > >>>>>>>>>> To: dev@aries.apache.org > >>>>>>>>>>=20 > >>>>>>>>>> Can someone point me to a process for deploying > >>>>>>>>>> blueprint-cm ? > >>>>>>>>>> It seems that bundle requires > >>>>>>>>>> org.apache.aries.blueprint.utils > >>>>>>>=20 > >>>>>>> package > >>>>>>>=20 > >>>>>>>>>> which isn't exported by any bundle afaik. > >>>>>>>>>>=20 > >>>>>>>>>> It really looks like the most recent changes in > >>>>>>>>>> blueprint completely>>>>>>>>>=20 > >>>>>>>>> broke > >>>>>>>>>=20 > >>>>>>>>>> the bundles .... > >>>>>>>>>> Thoughts welcome ( before I get really pissed ;-) ) > >>>>>>>>>>=20 > >>>>>>>>>> -- > >>>>>>>>>> ------------------------ > >>>>>>>>>> Guillaume Nodet > >>>>>>>>>> ------------------------ > >>>>>>>>>> Blog: http://gnodet.blogspot.com/ > >>>>>>>>>> ------------------------ > >>>>>>>>>> Open Source SOA > >>>>>>>>>> http://fusesource.com > >>>>>>>>=20 > >>>>>>>> -- > >>>>>>>> ------------------------ > >>>>>>>> Guillaume Nodet > >>>>>>>> ------------------------ > >>>>>>>> Blog: http://gnodet.blogspot.com/ > >>>>>>>> ------------------------ > >>>>>>>> Open Source SOA > >>>>>>>> http://fusesource.com > >>>>>>=20 > >>>>>> -- > >>>>>> ------------------------ > >>>>>> Guillaume Nodet > >>>>>> ------------------------ > >>>>>> Blog: http://gnodet.blogspot.com/ > >>>>>> ------------------------ > >>>>>> Open Source SOA > >>>>>> http://fusesource.com --=20 Daniel Kulp dkulp@apache.org http://dankulp.com/blog Talend - http://www.talend.com