Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 39079200D4F for ; Wed, 6 Dec 2017 10:23:04 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 37777160C08; Wed, 6 Dec 2017 09:23:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7D438160BFD for ; Wed, 6 Dec 2017 10:23:03 +0100 (CET) Received: (qmail 73774 invoked by uid 500); 6 Dec 2017 09:23:02 -0000 Mailing-List: contact issues-help@ariatosca.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ariatosca.incubator.apache.org Delivered-To: mailing list issues@ariatosca.incubator.apache.org Received: (qmail 73765 invoked by uid 99); 6 Dec 2017 09:23:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Dec 2017 09:23:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 0D50C1A12FD for ; Wed, 6 Dec 2017 09:23:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id HdktFcU423jV for ; Wed, 6 Dec 2017 09:23:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 0652F5F3CC for ; Wed, 6 Dec 2017 09:23:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 8588BE095C for ; Wed, 6 Dec 2017 09:23:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 37D75255BF for ; Wed, 6 Dec 2017 09:23:00 +0000 (UTC) Date: Wed, 6 Dec 2017 09:23:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@ariatosca.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ARIA-422) Parsing CSARs is broken MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 06 Dec 2017 09:23:04 -0000 [ https://issues.apache.org/jira/browse/ARIA-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279899#comment-16279899 ] ASF GitHub Bot commented on ARIA-422: ------------------------------------- tliron commented on a change in pull request #214: ARIA-422 Parsing CSARs is broken URL: https://github.com/apache/incubator-ariatosca/pull/214#discussion_r155181279 ########## File path: aria/utils/yaml.py ########## @@ -48,3 +48,8 @@ finally: from ruamel import yaml # pylint: disable=unused-import + + +# Enables support for writing python unicode class with yaml. This is a Temporary fix which +# should be replaced by a proper usage of ruamel. Review comment: Please fix this comment to specifically mention [ARIA-429](https://issues.apache.org/jira/browse/ARIA-429), the follow up. Also please use a capital letter for "Python", "Unicode", and all uppercase for "YAML". Also not need to capitalize "Temporary". Yes, this is very petty. :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org > Parsing CSARs is broken > ----------------------- > > Key: ARIA-422 > URL: https://issues.apache.org/jira/browse/ARIA-422 > Project: AriaTosca > Issue Type: Story > Reporter: Tal Liron > Assignee: Maxim Orlov > > ARIA creates csar with broken metadata (we need to support unicode fields) -- This message was sent by Atlassian JIRA (v6.4.14#64029)