ariatosca-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARIA-422) Parsing CSARs is broken
Date Wed, 06 Dec 2017 09:23:00 GMT

    [ https://issues.apache.org/jira/browse/ARIA-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279899#comment-16279899
] 

ASF GitHub Bot commented on ARIA-422:
-------------------------------------

tliron commented on a change in pull request #214: ARIA-422 Parsing CSARs is broken
URL: https://github.com/apache/incubator-ariatosca/pull/214#discussion_r155181279
 
 

 ##########
 File path: aria/utils/yaml.py
 ##########
 @@ -48,3 +48,8 @@
 
 finally:
     from ruamel import yaml                                                     # pylint:
disable=unused-import
+
+
+# Enables support for writing python unicode class with yaml. This is a Temporary fix which
+# should be replaced by a proper usage of ruamel.
 
 Review comment:
   Please fix this comment to specifically mention [ARIA-429](https://issues.apache.org/jira/browse/ARIA-429),
the follow up. Also please use a capital letter for "Python", "Unicode", and all uppercase
for "YAML". Also not need to capitalize "Temporary".
   
   Yes, this is very petty. :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Parsing CSARs is broken
> -----------------------
>
>                 Key: ARIA-422
>                 URL: https://issues.apache.org/jira/browse/ARIA-422
>             Project: AriaTosca
>          Issue Type: Story
>            Reporter: Tal Liron
>            Assignee: Maxim Orlov
>
> ARIA creates csar with broken metadata (we need to support unicode fields)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message