ariatosca-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARIA-199) Service outputs CLI command
Date Sun, 04 Jun 2017 13:32:04 GMT

    [ https://issues.apache.org/jira/browse/ARIA-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036272#comment-16036272
] 

ASF GitHub Bot commented on ARIA-199:
-------------------------------------

Github user AviaE commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/146#discussion_r120009119
  
    --- Diff: aria/cli/commands/services.py ---
    @@ -192,17 +192,17 @@ def outputs(service_name, model_storage, logger):
         """
         logger.info('Showing outputs for service {0}...'.format(service_name))
         service = model_storage.service.get_by_name(service_name)
    -    #TODO fix this section..
    -    outputs_def = service.outputs
    -    response = model_storage.service.outputs.get(service_name)
    -    outputs_ = StringIO()
    -    for output_name, output in response.outputs.iteritems():
    -        outputs_.write(' - "{0}":{1}'.format(output_name, os.linesep))
    -        description = outputs_def[output_name].get('description', '')
    -        outputs_.write('     Description: {0}{1}'.format(description,
    -                                                         os.linesep))
    -        outputs_.write('     Value: {0}{1}'.format(output, os.linesep))
    -    logger.info(outputs_.getvalue())
    +
    +    if service.outputs:
    +        outputs_ = StringIO()
    +        for output_name, output in service.outputs.iteritems():
    +            outputs_.write(' - "{0}":{1}'.format(output_name, os.linesep))
    +            outputs_.write('     Description: {0}{1}'.format(output.description,
    --- End diff --
    
    Put the `os.linesep` in the `Description` line in the same line. It is short enough =)


> Service outputs CLI command
> ---------------------------
>
>                 Key: ARIA-199
>                 URL: https://issues.apache.org/jira/browse/ARIA-199
>             Project: AriaTosca
>          Issue Type: Story
>            Reporter: Ran Ziv
>            Assignee: Tal Liron
>
> The {{aria services outputs}} command should evaluate the service's outputs and present
them to the user.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message