Mailing-List: contact issues-help@ariatosca.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ariatosca.incubator.apache.org
Date: Wed, 31 May 2017 19:05:06 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@ariatosca.apache.org
Message-ID: <JIRA.13066091.1492882780000.334636.1496257506598@Atlassian.JIRA>
In-Reply-To: <JIRA.13066091.1492882780000@Atlassian.JIRA>
References: <JIRA.13066091.1492882780000@Atlassian.JIRA> <JIRA.13066091.1492882780434@jira-lw-us.apache.org>
Subject: [jira] [Commented] (ARIA-149) Support instrinsic functions in
 "dependencies" operation configuration
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 31 May 2017 19:05:13 -0000


    [ https://issues.apache.org/jira/browse/ARIA-149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16031745#comment-16031745 ] 

ASF GitHub Bot commented on ARIA-149:
-------------------------------------

Github user ran-z commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119445992
  
    --- Diff: aria/modeling/utils.py ---
    @@ -51,74 +53,95 @@ def service_template(self):
             return self.container.service_template
     
     
    -def create_inputs(inputs, template_inputs):
    +def merge_parameter_values(parameter_values, declared_parameters, forbidden_names=None):
    --- End diff --
    
    what was the purpose of the changes to this method? im not sure i understand the benefit and it seems less readable now to me


> Support instrinsic functions in "dependencies" operation configuration
> ----------------------------------------------------------------------
>
>                 Key: ARIA-149
>                 URL: https://issues.apache.org/jira/browse/ARIA-149
>             Project: AriaTosca
>          Issue Type: Story
>            Reporter: Tal Liron
>            Assignee: Tal Liron
>
> There are a few issues here. First, the following YAML is totally broken;
> {code}
>               dependencies:
>                 - ssh.address > { get_attribute: virtual_ip.floating_ip }
> {code}
> The problem is that in YAML, due to the location of the ":", this gets parsed as a dict where the key is {code}ssh.address > { get_attribute{code} and the value is {code}virtual_ip.floating_ip }{code} which is not what we want at all.
> The solution is to encase the whole value in quotes to enforce parsing as a string:
> {code}
>               dependencies:
>                 - "ssh.address > { get_attribute: virtual_ip.floating_ip }"
> {code}
> Note that the one attractive solution is to to change this ">" format to a real dict. So:
> {code}
>               dependencies:
>                 - { ssh.address: { get_attribute: virtual_ip.floating_ip } }
> {code}
> But this will break other TOSCA parsers that expect a string here, so no go. :(


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)