Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 8AF3A200CA8 for ; Wed, 31 May 2017 20:58:08 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 895F0160BC2; Wed, 31 May 2017 18:58:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D0925160BCB for ; Wed, 31 May 2017 20:58:07 +0200 (CEST) Received: (qmail 30503 invoked by uid 500); 31 May 2017 18:58:07 -0000 Mailing-List: contact issues-help@ariatosca.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ariatosca.incubator.apache.org Delivered-To: mailing list issues@ariatosca.incubator.apache.org Received: (qmail 30473 invoked by uid 99); 31 May 2017 18:58:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 31 May 2017 18:58:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 6D40C1AFAB1 for ; Wed, 31 May 2017 18:58:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id S-h_VNRYY5QE for ; Wed, 31 May 2017 18:58:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 5209D5F295 for ; Wed, 31 May 2017 18:58:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id DCDF4E0373 for ; Wed, 31 May 2017 18:58:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 9C9AB2193C for ; Wed, 31 May 2017 18:58:04 +0000 (UTC) Date: Wed, 31 May 2017 18:58:04 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@ariatosca.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ARIA-149) Support instrinsic functions in "dependencies" operation configuration MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 31 May 2017 18:58:08 -0000 [ https://issues.apache.org/jira/browse/ARIA-149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16031712#comment-16031712 ] ASF GitHub Bot commented on ARIA-149: ------------------------------------- Github user ran-z commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119443983 --- Diff: aria/modeling/exceptions.py --- @@ -22,9 +22,9 @@ class ModelingException(AriaException): """ -class InputsException(ModelingException): +class ParameterException(ModelingException): --- End diff -- :+1: > Support instrinsic functions in "dependencies" operation configuration > ---------------------------------------------------------------------- > > Key: ARIA-149 > URL: https://issues.apache.org/jira/browse/ARIA-149 > Project: AriaTosca > Issue Type: Story > Reporter: Tal Liron > Assignee: Tal Liron > > There are a few issues here. First, the following YAML is totally broken; > {code} > dependencies: > - ssh.address > { get_attribute: virtual_ip.floating_ip } > {code} > The problem is that in YAML, due to the location of the ":", this gets parsed as a dict where the key is {code}ssh.address > { get_attribute{code} and the value is {code}virtual_ip.floating_ip }{code} which is not what we want at all. > The solution is to encase the whole value in quotes to enforce parsing as a string: > {code} > dependencies: > - "ssh.address > { get_attribute: virtual_ip.floating_ip }" > {code} > Note that the one attractive solution is to to change this ">" format to a real dict. So: > {code} > dependencies: > - { ssh.address: { get_attribute: virtual_ip.floating_ip } } > {code} > But this will break other TOSCA parsers that expect a string here, so no go. :( -- This message was sent by Atlassian JIRA (v6.3.15#6346)