ariatosca-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARIA-149) Support instrinsic functions in "dependencies" operation configuration
Date Wed, 31 May 2017 19:02:04 GMT

    [ https://issues.apache.org/jira/browse/ARIA-149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16031731#comment-16031731
] 

ASF GitHub Bot commented on ARIA-149:
-------------------------------------

Github user ran-z commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119445302
  
    --- Diff: tests/orchestrator/test_workflow_runner.py ---
    @@ -259,8 +258,9 @@ def _setup_mock_workflow_in_service(request, inputs=None):
         workflow = models.Operation(
             name=mock_workflow_name,
             service=service,
    -        implementation='workflow.mock_workflow',
    -        inputs=inputs or {})
    +        function='workflow.mock_workflow',
    +        inputs=inputs or {},
    +        arguments=inputs or {})
    --- End diff --
    
    why is this needed? wouldn't arguments get auto-populated with inputs anyway?


> Support instrinsic functions in "dependencies" operation configuration
> ----------------------------------------------------------------------
>
>                 Key: ARIA-149
>                 URL: https://issues.apache.org/jira/browse/ARIA-149
>             Project: AriaTosca
>          Issue Type: Story
>            Reporter: Tal Liron
>            Assignee: Tal Liron
>
> There are a few issues here. First, the following YAML is totally broken;
> {code}
>               dependencies:
>                 - ssh.address > { get_attribute: virtual_ip.floating_ip }
> {code}
> The problem is that in YAML, due to the location of the ":", this gets parsed as a dict
where the key is {code}ssh.address > { get_attribute{code} and the value is {code}virtual_ip.floating_ip
}{code} which is not what we want at all.
> The solution is to encase the whole value in quotes to enforce parsing as a string:
> {code}
>               dependencies:
>                 - "ssh.address > { get_attribute: virtual_ip.floating_ip }"
> {code}
> Note that the one attractive solution is to to change this ">" format to a real dict.
So:
> {code}
>               dependencies:
>                 - { ssh.address: { get_attribute: virtual_ip.floating_ip } }
> {code}
> But this will break other TOSCA parsers that expect a string here, so no go. :(



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message