Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id F04B5200C73 for ; Wed, 10 May 2017 16:51:09 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id EEE6D160BA8; Wed, 10 May 2017 14:51:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 403BE160B9C for ; Wed, 10 May 2017 16:51:09 +0200 (CEST) Received: (qmail 971 invoked by uid 500); 10 May 2017 14:51:08 -0000 Mailing-List: contact dev-help@ariatosca.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ariatosca.incubator.apache.org Delivered-To: mailing list dev@ariatosca.incubator.apache.org Received: (qmail 958 invoked by uid 99); 10 May 2017 14:51:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 May 2017 14:51:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 1CF86C0922 for ; Wed, 10 May 2017 14:51:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id PdzIXs0udZjb for ; Wed, 10 May 2017 14:51:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 4B6885FC43 for ; Wed, 10 May 2017 14:51:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 8DC92E01A8 for ; Wed, 10 May 2017 14:51:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 54BC421E0A for ; Wed, 10 May 2017 14:51:04 +0000 (UTC) Date: Wed, 10 May 2017 14:51:04 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: dev@ariatosca.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ARIA-157) CLI unit tests for storing service-templates fail on appveyor MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 10 May 2017 14:51:10 -0000 [ https://issues.apache.org/jira/browse/ARIA-157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16004811#comment-16004811 ] ASF subversion and git services commented on ARIA-157: ------------------------------------------------------ Commit ca49ae016962a260e0363522482e453b18db024f in incubator-ariatosca's branch refs/heads/ARIA-157-cli-service-template-store-tests-fail-in-windows from [~avia] [ https://git-wip-us.apache.org/repos/asf?p=incubator-ariatosca.git;h=ca49ae0 ] ARIA-157 Failing CLI service-templates store tests on Windows Three tests from `aria service-templates store` failed on Windows, but not on Linux. The reason for this failures was differing implementation of os.path.dirname across the platfroms. Python implements os.path.dirname in the ntpath module. There, somewhere down the line of calls, (a part of) the argument of dirname is tested for membership in a string (using `in`). In these three tests, the argument of dirname is of type MagicMock, and an error is raised since only a string can be tested for memebership in a string. The solution was to mock the dirname calls. > CLI unit tests for storing service-templates fail on appveyor > ------------------------------------------------------------- > > Key: ARIA-157 > URL: https://issues.apache.org/jira/browse/ARIA-157 > Project: AriaTosca > Issue Type: Bug > Reporter: Avia Efrat > Assignee: Avia Efrat > > The failing tests are: > test_store_no_exception > test_store_raises_exception_resulting_from_name_uniqueness > test_store_raises_exception > They pass on Travis. -- This message was sent by Atlassian JIRA (v6.3.15#6346)