Mailing-List: contact dev-help@ariatosca.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ariatosca.incubator.apache.org
From: ran-z <git@git.apache.org>
To: dev@ariatosca.incubator.apache.org
Reply-To: dev@ariatosca.incubator.apache.org
References: <git-pr-107-incubator-ariatosca@git.apache.org>
In-Reply-To: <git-pr-107-incubator-ariatosca@git.apache.org>
Subject: [GitHub] incubator-ariatosca pull request #107: ARIA-148 CLI display commands
Content-Type: text/plain
Message-Id: <20170503141719.DB173E0896@git1-us-west.apache.org>
Date: Wed,  3 May 2017 14:17:19 +0000 (UTC)
archived-at: Wed, 03 May 2017 14:17:27 -0000

Github user ran-z commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/107#discussion_r114554248
  
    --- Diff: aria/cli/commands/services.py ---
    @@ -177,3 +179,31 @@ def inputs(service_name, model_storage, logger):
             logger.info(inputs_string.getvalue())
         else:
             logger.info('\tNo inputs')
    +
    +
    +@services.command(name='display',
    +                  short_help='Display service information')
    +@aria.argument('service-name')
    +@aria.options.verbose()
    +@aria.options.display_json
    +@aria.options.display_yaml
    +@aria.options.display_graph
    +@aria.pass_model_storage
    +@aria.pass_logger
    +def display(service_name, model_storage, json, yaml, graph, logger):
    --- End diff --
    
    nitpicking that model_storage should probably sit after `graph`, before `logger`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---