ariatosca-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From AviaE <...@git.apache.org>
Subject [GitHub] incubator-ariatosca pull request #121: ARIA-143 Better handle exceptions in ...
Date Sun, 07 May 2017 09:30:01 GMT
GitHub user AviaE opened a pull request:

    https://github.com/apache/incubator-ariatosca/pull/121

    ARIA-143 Better handle exceptions in the process executor

    Previously, if an exception was raised during the starting of a task,
    the task's process was permenantly blocked on receiving a message.
    
    The reason was that the execption caused the 'listener thread' to
    not send a response the to the task's process, as the exception was not handled inside
the 'with' block of the listener thread.
    
    The first change I introduced was to wrap the yielding of the message and
    the response inside a try-except-finally block, so the exception will be
    handled within the 'with' scope, and to ensure a response is sent to the
    task's process.
    
    The second change is to move the sending of the 'task started' message in
    the task's process to a place where encountering an exception will be
    handled via sending a 'task failed' message back to the listener thread.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/incubator-ariatosca ARIA-143-better-handle-exceptions-in-the-process-executor

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-ariatosca/pull/121.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #121
    
----
commit e5c6522cfefffe699ab742c790d102ebce227090
Author: Avia Efrat <avia@gigaspaces.com>
Date:   2017-05-07T08:42:58Z

    ARIA-143 Better handle exceptions in the process executor
    
    Previously, if an exception was raised during the starting of a task,
    the task's process was permenantly blocked on receiving a message.
    
    The reason was that the execption caused the 'listener thread' to
    not send a response the to the task's process, as the exception was not handled inside
the 'with' block of the listener thread.
    
    The first change I introduced was to wrap the yielding of the message and
    the response inside a try-except-finally block, so the exception will be
    handled within the 'with' scope, and to ensure a response is sent to the
    task's process.
    
    The second change is to move the sending of the 'task started' message in
    the task's process to a place where encountering an exception will be
    handled via sending a 'task failed' message back to the listener thread.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message