ariatosca-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <>
Subject [jira] [Commented] (ARIA-156) Workflow runner continues to run when exception is raised on task_started event
Date Tue, 09 May 2017 20:38:04 GMT


ASF subversion and git services commented on ARIA-156:

Commit 1cb3086f38bc35a6a5e588aa5e340cb4fa5cacf5 in incubator-ariatosca's branch refs/heads/ARIA-140-version-utils
from [~avia]
[;h=1cb3086 ]

ARIA-156 Better handle exceptions in the process executor

Previously, if an exception was raised during the starting of a task,
the task's process was permanently blocked on receiving a message.

The reason was that the exception caused the 'listener thread' to
not send a response to the task's process, as the exception was not
handled inside the 'with' block of the listener thread.

The first change I introduced was to wrap the yielding of the message and
the response inside a try-except-finally block, so the exception will be
handled within the 'with' scope, and to ensure a response is sent to the
task's process.

The second change is to move the sending of the 'task started' message in
the task's process to a place where encountering an exception will be
handled via sending a 'task failed' message back to the listener thread.

> Workflow runner continues to run when exception is raised on task_started event
> -------------------------------------------------------------------------------
>                 Key: ARIA-156
>                 URL:
>             Project: AriaTosca
>          Issue Type: Bug
>    Affects Versions: 0.1.0
>            Reporter: Avia Efrat
>            Assignee: Avia Efrat
>             Fix For: 0.1.0
> If an exception is raised during _task_started, the engine continues to run, but it finds
no executable tasks or ended tasks.

This message was sent by Atlassian JIRA

View raw message