ariatosca-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARIA-156) Workflow runner continues to run when exception is raised on task_started event
Date Sun, 07 May 2017 10:19:04 GMT

    [ https://issues.apache.org/jira/browse/ARIA-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15999771#comment-15999771
] 

ASF GitHub Bot commented on ARIA-156:
-------------------------------------

GitHub user AviaE opened a pull request:

    https://github.com/apache/incubator-ariatosca/pull/122

    ARIA-156 Better handle exceptions in the process executor

    Previously, if an exception was raised during the starting of a task,
    the task's process was permenantly blocked on receiving a message.
    
    The reason was that the execption caused the 'listener thread' to
    not send a response the to the task's process, as the exception was not handled inside
the 'with' block of the listener thread.
    
    The first change I introduced was to wrap the yielding of the message and
    the response inside a try-except-finally block, so the exception will be
    handled within the 'with' scope, and to ensure a response is sent to the
    task's process.
    
    The second change is to move the sending of the 'task started' message in
    the task's process to a place where encountering an exception will be
    handled via sending a 'task failed' message back to the listener thread.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/incubator-ariatosca ARIA-156-better-handle-exceptions-in-the-process-executor

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-ariatosca/pull/122.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #122
    
----
commit 7bc6d8a94a5b06d9c0719a7026077f96489e6d89
Author: Avia Efrat <avia@gigaspaces.com>
Date:   2017-05-07T08:42:58Z

    ARIA-156 Better handle exceptions in the process executor
    
    Previously, if an exception was raised during the starting of a task,
    the task's process was permenantly blocked on receiving a message.
    
    The reason was that the execption caused the 'listener thread' to
    not send a response the to the task's process, as the exception was not handled inside
the 'with' block of the listener thread.
    
    The first change I introduced was to wrap the yielding of the message and
    the response inside a try-except-finally block, so the exception will be
    handled within the 'with' scope, and to ensure a response is sent to the
    task's process.
    
    The second change is to move the sending of the 'task started' message in
    the task's process to a place where encountering an exception will be
    handled via sending a 'task failed' message back to the listener thread.

----


> Workflow runner continues to run when exception is raised on task_started event
> -------------------------------------------------------------------------------
>
>                 Key: ARIA-156
>                 URL: https://issues.apache.org/jira/browse/ARIA-156
>             Project: AriaTosca
>          Issue Type: Bug
>    Affects Versions: 0.1.0
>            Reporter: Avia Efrat
>            Assignee: Avia Efrat
>
> If an exception is raised during _task_started, the engine continues to run, but it finds
no executable tasks or ended tasks.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message