ariatosca-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARIA-140) General purpose version comparison
Date Mon, 08 May 2017 15:47:04 GMT

    [ https://issues.apache.org/jira/browse/ARIA-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000943#comment-16000943
] 

ASF GitHub Bot commented on ARIA-140:
-------------------------------------

Github user tliron commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/100#discussion_r115281253
  
    --- Diff: aria/utils/versions.py ---
    @@ -0,0 +1,162 @@
    +# Licensed to the Apache Software Foundation (ASF) under one or more
    +# contributor license agreements.  See the NOTICE file distributed with
    +# this work for additional information regarding copyright ownership.
    +# The ASF licenses this file to You under the Apache License, Version 2.0
    +# (the "License"); you may not use this file except in compliance with
    +# the License.  You may obtain a copy of the License at
    +#
    +#     http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing, software
    +# distributed under the License is distributed on an "AS IS" BASIS,
    +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +# See the License for the specific language governing permissions and
    +# limitations under the License.
    +
    +"""
    +General-purpose version string handling
    +"""
    +
    +import re
    +
    +
    +_INF = float('inf')
    +
    +_NULL = (), _INF
    --- End diff --
    
    Because "Numeric qualifiers will always be greater than prefixed integer qualifiers, e.g.
"1.1-1" > "1.1-beta1". The qualifier is a float that is an extra, but if the qualifier
is not present "infinity" should always win over it. It shouldn't matter what's "more natural"
seeming: this is an underscored internal var that's never seen by users of the lib.


> General purpose version comparison
> ----------------------------------
>
>                 Key: ARIA-140
>                 URL: https://issues.apache.org/jira/browse/ARIA-140
>             Project: AriaTosca
>          Issue Type: Story
>            Reporter: Tal Liron
>            Assignee: Tal Liron
>            Priority: Minor
>
> Add {{aria.utils.versions}} to allow for general-purpose comparison and sorting of version
strings.
> For now this will be used for resolving plugin specifications to plugins, but it may
very well have other uses in the future.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message