ariatosca-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ran-z <...@git.apache.org>
Subject [GitHub] incubator-ariatosca pull request #107: ARIA-148 CLI display commands
Date Thu, 11 May 2017 08:47:58 GMT
Github user ran-z commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/107#discussion_r115934893
  
    --- Diff: aria/cli/core/aria.py ---
    @@ -40,16 +41,8 @@
     
     
     class MutuallyExclusiveOption(click.Option):
    -    """Makes options mutually exclusive. The option must pass a `cls` argument
    -    with this class name and a `mutually_exclusive` argument with a list of
    -    argument names it is mutually exclusive with.
    -
    -    NOTE: All mutually exclusive options must use this. It's not enough to
    -    use it in just one of the options.
    -    """
    -
         def __init__(self, *args, **kwargs):
    -        self.mutually_exclusive = set(kwargs.pop('mutually_exclusive', []))
    +        self.mutually_exclusive = kwargs.pop('mutually_exclusive', tuple())
    --- End diff --
    
    why change this from a set to another type?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message