ariatosca-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ran-z <...@git.apache.org>
Subject [GitHub] incubator-ariatosca pull request #107: ARIA-148 CLI display commands
Date Wed, 10 May 2017 12:30:04 GMT
Github user ran-z commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/107#discussion_r115726390
  
    --- Diff: aria/cli/commands/services.py ---
    @@ -38,6 +41,53 @@ def services():
         pass
     
     
    +@services.command(name='show',
    +                  short_help='Display service information')
    +@aria.argument('service-name')
    +@aria.options.verbose()
    +@aria.options.show_all
    +@aria.options.show_graph
    +@aria.options.show_json
    +@aria.options.show_yaml
    +@aria.pass_model_storage
    +@aria.pass_logger
    +def show(service_name, model_storage, all, graph, json, yaml, logger):
    +    """Show information for a specific service template
    +
    +    `SERVICE_NAME` is the name of the service to display information on.
    +    """
    +    logger.info('Showing service {0}...'.format(service_name))
    +    service = model_storage.service.get_by_name(service_name)
    +
    +    if json or yaml:
    +        all = True
    --- End diff --
    
    i'd rename the flag, it's both unclear and a python keyword. `show_all` or `all_info`
might be better.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message