ariatosca-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tliron <...@git.apache.org>
Subject [GitHub] incubator-ariatosca pull request #100: ARIA-140 Version utils
Date Mon, 08 May 2017 15:48:44 GMT
Github user tliron commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/100#discussion_r115281803
  
    --- Diff: aria/utils/versions.py ---
    @@ -0,0 +1,162 @@
    +# Licensed to the Apache Software Foundation (ASF) under one or more
    +# contributor license agreements.  See the NOTICE file distributed with
    +# this work for additional information regarding copyright ownership.
    +# The ASF licenses this file to You under the Apache License, Version 2.0
    +# (the "License"); you may not use this file except in compliance with
    +# the License.  You may obtain a copy of the License at
    +#
    +#     http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing, software
    +# distributed under the License is distributed on an "AS IS" BASIS,
    +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +# See the License for the specific language governing permissions and
    +# limitations under the License.
    +
    +"""
    +General-purpose version string handling
    +"""
    +
    +import re
    +
    +
    +_INF = float('inf')
    +
    +_NULL = (), _INF
    --- End diff --
    
    Because "Numeric qualifiers will always be greater than prefixed integer qualifiers, e.g.
"1.1-1" > "1.1-beta1". The qualifier is a float that is an extra, but if the qualifier
is not present "infinity" should always win over it. It shouldn't matter what's "more natural"
seeming: this is an underscored internal var that's never seen by users of the lib. Users
instead use `VersionString.NULL` or can init `VersionString` with None.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message