Mailing-List: contact dev-help@ariatosca.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ariatosca.incubator.apache.org
Date: Thu, 13 Apr 2017 17:28:41 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@ariatosca.incubator.apache.org
Message-ID: <JIRA.13039447.1485952048000.277778.1492104521662@Atlassian.JIRA>
In-Reply-To: <JIRA.13039447.1485952048000@Atlassian.JIRA>
References: <JIRA.13039447.1485952048000@Atlassian.JIRA> <JIRA.13039447.1485952048188@jira-lw-us.apache.org>
Subject: [jira] [Commented] (ARIA-92) Execution plugin operations default
 mappings
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 13 Apr 2017 17:28:46 -0000


    [ https://issues.apache.org/jira/browse/ARIA-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15967931#comment-15967931 ] 

ASF GitHub Bot commented on ARIA-92:
------------------------------------

Github user tliron commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/95#discussion_r111443166
  
    --- Diff: extensions/aria_extension_tosca/simple_v1_0/modeling/__init__.py ---
    @@ -352,20 +359,44 @@ def create_interface_template_model(context, service_template, interface):
         return model if model.operation_templates else None
     
     
    -def create_operation_template_model(context, service_template, operation): # pylint: disable=unused-argument
    +def create_operation_template_model(context, service_template, operation):
         model = OperationTemplate(name=operation._name)
     
         if operation.description:
             model.description = operation.description.value
     
         implementation = operation.implementation
    -    if (implementation is not None) and operation.implementation.primary:
    -        model.plugin_specification, model.implementation = \
    -            parse_implementation_string(context, service_template, operation.implementation.primary)
    -
    +    if implementation is not None: 
    +        primary = implementation.primary
    +        plugin_name, model.implementation = split_prefix(primary)
    +        if plugin_name is not None:
    +            model.plugin_specification = service_template.plugin_specifications.get(plugin_name)
    +            if model.plugin_specification is None:
    +                context.validation.report(
    +                    'unknown plugin "%s" specified in operation implementation: %s'
    +                    % (plugin_name, primary),
    +                    locator=operation._get_child_locator('implementation', 'primary'),
    +                    level=Issue.BETWEEN_TYPES)
    +    
    +        relationship_edge = operation._get_extensions(context).get('relationship_edge')
    +        if relationship_edge is not None:
    --- End diff --
    
    We agreed that it's better to keep this "edge was not set" information.


> Execution plugin operations default mappings
> --------------------------------------------
>
>                 Key: ARIA-92
>                 URL: https://issues.apache.org/jira/browse/ARIA-92
>             Project: AriaTosca
>          Issue Type: Story
>            Reporter: Ran Ziv
>            Assignee: Tal Liron
>
> The execution plugin serves as the default plugin, i.e. if no other plugin was specified, it'll be used to execute scripts in operations.
> These scripts will currently only execute locally. The execution plugin also supports running scripts on remote machines (via SSH).
> One option is to have the parser recognize whether the node in question is contained inside a host node, in which case the script should be executed remotely (by default, yet overridable by specifying the full plugin operation mapping), and if not then it should be executed locally.
> Another option is to have the user specify it using special syntax, e.g.:
> "local > script.sh" and "remote > script.sh"


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)