Mailing-List: contact dev-help@ariatosca.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ariatosca.incubator.apache.org
From: tliron <git@git.apache.org>
To: dev@ariatosca.incubator.apache.org
Reply-To: dev@ariatosca.incubator.apache.org
References: <git-pr-91-incubator-ariatosca@git.apache.org>
In-Reply-To: <git-pr-91-incubator-ariatosca@git.apache.org>
Subject: [GitHub] incubator-ariatosca pull request #91: ARIA-134 Parser populates service work...
Content-Type: text/plain
Message-Id: <20170405155751.95546DFC8E@git1-us-west.apache.org>
Date: Wed,  5 Apr 2017 15:57:51 +0000 (UTC)
archived-at: Wed, 05 Apr 2017 15:57:56 -0000

Github user tliron commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/91#discussion_r109956337
  
    --- Diff: extensions/aria_extension_tosca/simple_v1_0/modeling/__init__.py ---
    @@ -85,9 +85,14 @@ def create_service_template_model(context): # pylint: disable=too-many-locals,to
         policies = context.presentation.get('service_template', 'topology_template', 'policies')
         if policies:
             for policy in policies.itervalues():
    -            if model.policy_types.get_descendant(policy.type).role == 'plugin':
    +            role = model.policy_types.get_descendant(policy.type).role
    --- End diff --
    
    *All* the policies are added in line 115, below. Well, I think we *have* to add all of them because they are there in the TOSCA service template. The fact that ARIA recognizes some special roles doesn't mean they aren't policies, still.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---