Mailing-List: contact dev-help@ariatosca.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ariatosca.incubator.apache.org
From: tliron <git@git.apache.org>
To: dev@ariatosca.incubator.apache.org
Reply-To: dev@ariatosca.incubator.apache.org
References: <git-pr-95-incubator-ariatosca@git.apache.org>
In-Reply-To: <git-pr-95-incubator-ariatosca@git.apache.org>
Subject: [GitHub] incubator-ariatosca pull request #95: ARIA-92 Automatic operation task confi...
Content-Type: text/plain
Message-Id: <20170405154746.581A9E9624@git1-us-west.apache.org>
Date: Wed,  5 Apr 2017 15:47:46 +0000 (UTC)
archived-at: Wed, 05 Apr 2017 15:47:53 -0000

Github user tliron commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/95#discussion_r109947108
  
    --- Diff: tests/modeling/test_models.py ---
    @@ -583,48 +583,49 @@ def test_node_model_creation(self, node_template_storage, is_valid, name, runtim
                        node_template_storage.service.list()[0]
     
     
    -class TestNodeIP(object):
    +class TestNodeHostAddress(object):
    --- End diff --
    
    That whole part of the code (finding the "ip") had to be refactored because it was essentially broken. As I was changing it anyway it made sense to change the name. It's really not hard to change back.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---