ariatosca-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARIA-136) ctx binary doesn't get installed via pip install
Date Mon, 03 Apr 2017 08:36:41 GMT

    [ https://issues.apache.org/jira/browse/ARIA-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15953130#comment-15953130
] 

ASF GitHub Bot commented on ARIA-136:
-------------------------------------

Github user ran-z commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/93#discussion_r109363605
  
    --- Diff: setup.py ---
    @@ -63,20 +64,43 @@
     console_scripts = ['aria = aria.cli.cli:main']
     
     
    -class InstallCommand(install):
    -    user_options = install.user_options + [
    +def _generate_user_options(command):
    +    return command.user_options + [
             ('skip-ctx', None, 'Install with or without the ctx (Defaults to False)')
         ]
    -    boolean_options = install.boolean_options + ['skip-ctx']
     
    -    def initialize_options(self):
    -        install.initialize_options(self)
    -        self.skip_ctx = False
     
    -    def run(self):
    -        if self.skip_ctx is False:
    -            console_scripts.append('ctx = aria.orchestrator.execution_plugin.ctx_proxy.client:main')
    -        install.run(self)
    +def _generate_boolean_options(command):
    +    return command.boolean_options + ['skip-ctx']
    +
    +
    +def _initialize_options(custom_cmd):
    --- End diff --
    
    who's actually calling this?


> ctx binary doesn't get installed via pip install
> ------------------------------------------------
>
>                 Key: ARIA-136
>                 URL: https://issues.apache.org/jira/browse/ARIA-136
>             Project: AriaTosca
>          Issue Type: Bug
>            Reporter: Ran Ziv
>            Assignee: Maxim Orlov
>            Priority: Minor
>
> the ctx binary is conditionally installed in {{setup.py}}, but it would seem the {{pip
install}} command does not install it as intended when installing in editable mode ({{-e}}
option)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message