ariatosca-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARIA-92) Execution plugin operations default mappings
Date Fri, 14 Apr 2017 18:30:41 GMT

    [ https://issues.apache.org/jira/browse/ARIA-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15969363#comment-15969363
] 

ASF GitHub Bot commented on ARIA-92:
------------------------------------

Github user ran-z commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/95#discussion_r111615833
  
    --- Diff: aria/modeling/service_template.py ---
    @@ -1864,13 +1865,21 @@ def as_raw(self):
     
         def instantiate(self, container):
             from . import models
    -        plugin = self.plugin_specification.find_plugin() \
    -            if self.plugin_specification is not None else None
    +        if self.plugin_specification and self.plugin_specification.enabled:
    +            plugin = self.plugin_specification.plugin
    +            implementation = self.implementation if plugin is not None else None
    +            # "plugin" would be none if a match was not found. In that case, a validation
error
    --- End diff --
    
    im not sure i understood this comment.
    i think you're trying to say that `plugin` can't be None here since the test for enabled
has already been performed earlier?
    the first line of the comment makes it sound like `plugin` can be None when it cant


> Execution plugin operations default mappings
> --------------------------------------------
>
>                 Key: ARIA-92
>                 URL: https://issues.apache.org/jira/browse/ARIA-92
>             Project: AriaTosca
>          Issue Type: Story
>            Reporter: Ran Ziv
>            Assignee: Tal Liron
>
> The execution plugin serves as the default plugin, i.e. if no other plugin was specified,
it'll be used to execute scripts in operations.
> These scripts will currently only execute locally. The execution plugin also supports
running scripts on remote machines (via SSH).
> One option is to have the parser recognize whether the node in question is contained
inside a host node, in which case the script should be executed remotely (by default, yet
overridable by specifying the full plugin operation mapping), and if not then it should be
executed locally.
> Another option is to have the user specify it using special syntax, e.g.:
> "local > script.sh" and "remote > script.sh"



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message