ariatosca-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxmrlv <...@git.apache.org>
Subject [GitHub] incubator-ariatosca pull request #114: ARIA-155 Clean models from unused fie...
Date Sun, 30 Apr 2017 12:26:11 GMT
Github user mxmrlv commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/114#discussion_r114074254
  
    --- Diff: tests/modeling/test_models.py ---
    @@ -206,31 +206,26 @@ def test_service_template_model_creation(self, empty_storage, is_valid,
descript
     class TestService(object):
     
         @pytest.mark.parametrize(
    -        'is_valid, name, created_at, description, inputs, permalink, '
    -        'outputs, scaling_groups, updated_at',
    +        'is_valid, name, created_at, description, inputs, '
    +        'outputs, updated_at',
             [
    -            (False, m_cls, now, 'desc', {}, 'perlnk', {}, {}, now),
    -            (False, 'name', m_cls, 'desc', {}, 'perlnk', {}, {}, now),
    -            (False, 'name', now, m_cls, {}, 'perlnk', {}, {}, now),
    -            (False, 'name', now, 'desc', {}, m_cls, {}, {}, now),
    -            (False, 'name', now, 'desc', {}, 'perlnk', m_cls, {}, now),
    -            (False, 'name', now, 'desc', {}, 'perlnk', {}, m_cls, now),
    -            (False, 'name', now, 'desc', {}, 'perlnk', {}, {}, m_cls),
    -
    -            (True, 'name', now, 'desc', {}, 'perlnk', {}, {}, now),
    -            (True, None, now, 'desc', {}, 'perlnk', {}, {}, now),
    -            (True, 'name', now, 'desc', {}, 'perlnk', {}, {}, now),
    -            (True, 'name', now, None, {}, 'perlnk', {}, {}, now),
    -            (True, 'name', now, 'desc', {}, 'perlnk', {}, {}, now),
    -            (True, 'name', now, 'desc', {}, None, {}, {}, now),
    -            (True, 'name', now, 'desc', {}, 'perlnk', {}, {}, now),
    -            (True, 'name', now, 'desc', {}, 'perlnk', {}, None, now),
    -            (True, 'name', now, 'desc', {}, 'perlnk', {}, {}, None),
    -            (True, 'name', now, 'desc', {}, 'perlnk', {}, {}, now),
    +            (False, m_cls, now, 'desc', {}, {}, now),
    +            (False, 'name', m_cls, 'desc', {}, {}, now),
    +            (False, 'name', now, m_cls, {}, {}, now),
    +            (False, 'name', now, 'desc', m_cls, {}, now),
    +            (False, 'name', now, 'desc', {}, m_cls, now),
    +            (False, 'name', now, 'desc', {}, {}, m_cls),
    +
    +            (True, 'name', now, 'desc', {}, {}, now),
    +            (True, None, now, 'desc', {}, {}, now),
    +            (True, 'name', now, None, {}, {}, now),
    +            (True, 'name', now, 'desc', {}, {}, now),
    +            (True, 'name', now, 'desc', {}, {}, None),
    +            (True, 'name', now, 'desc', {}, {}, now),
    --- End diff --
    
    same as line 222 and 219


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message