ariatosca-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxmrlv <...@git.apache.org>
Subject [GitHub] incubator-ariatosca pull request #114: ARIA-155 Clean models from unused fie...
Date Sun, 30 Apr 2017 12:26:11 GMT
Github user mxmrlv commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/114#discussion_r114074281
  
    --- Diff: tests/modeling/test_models.py ---
    @@ -549,23 +540,23 @@ def test_node_template_model_creation(self, service_storage, is_valid,
name, def
     
     class TestNode(object):
         @pytest.mark.parametrize(
    -        'is_valid, name, runtime_properties, scaling_groups, state, version',
    +        'is_valid, name, runtime_properties, state, version',
             [
    -            (False, m_cls, {}, [], 'state', 1),
    -            (False, 'name', m_cls, [], 'state', 1),
    -            (False, 'name', {}, m_cls, 'state', 1),
    -            (False, 'name', {}, [], m_cls, 1),
    -            (False, m_cls, {}, [], 'state', m_cls),
    -
    -            (True, 'name', {}, [], 'initial', 1),
    -            (True, None, {}, [], 'initial', 1),
    -            (True, 'name', None, [], 'initial', 1),
    -            (True, 'name', {}, None, 'initial', 1),
    -            (True, 'name', {}, [], 'initial', None),
    +            (False, m_cls, {}, 'state', 1),
    +            (False, 'name', m_cls, 'state', 1),
    +            (False, 'name', {}, 'state', 1),
    +            (False, 'name', {}, m_cls, 1),
    +            (False, m_cls, {}, 'state', m_cls),
    +
    +            (True, 'name', {}, 'initial', 1),
    +            (True, None, {}, 'initial', 1),
    +            (True, 'name', None, 'initial', 1),
    +            (True, 'name', {}, 'initial', 1),
    --- End diff --
    
    same as 551


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message