ariatosca-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxmrlv <...@git.apache.org>
Subject [GitHub] incubator-ariatosca pull request #103: ARIA-138-Make-logging-more-informativ...
Date Wed, 19 Apr 2017 14:05:06 GMT
Github user mxmrlv commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/103#discussion_r112209345
  
    --- Diff: aria/cli/commands/executions.py ---
    @@ -141,13 +143,19 @@ def start(workflow_name,
     
         logger.info('Starting {0}execution. Press Ctrl+C cancel'.format('dry ' if dry else
''))
         execution_thread.start()
    +
    +    log_consumer = cli_logger.ModelLogConsumer(model_storage, workflow_runner.execution_id)
         try:
             while execution_thread.is_alive():
    -            # using join without a timeout blocks and ignores KeyboardInterrupt
    -            execution_thread.join(1)
    +            for log in log_consumer:
    +                execution_logging.load(log).log()
    +
         except KeyboardInterrupt:
             _cancel_execution(workflow_runner, execution_thread, logger)
     
    +    for log in log_consumer:
    --- End diff --
    
    add comment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message