ariatosca-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ran-z <...@git.apache.org>
Subject [GitHub] incubator-ariatosca pull request #95: ARIA-92 Automatic operation task confi...
Date Fri, 14 Apr 2017 18:30:09 GMT
Github user ran-z commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/95#discussion_r111615833
  
    --- Diff: aria/modeling/service_template.py ---
    @@ -1864,13 +1865,21 @@ def as_raw(self):
     
         def instantiate(self, container):
             from . import models
    -        plugin = self.plugin_specification.find_plugin() \
    -            if self.plugin_specification is not None else None
    +        if self.plugin_specification and self.plugin_specification.enabled:
    +            plugin = self.plugin_specification.plugin
    +            implementation = self.implementation if plugin is not None else None
    +            # "plugin" would be none if a match was not found. In that case, a validation
error
    --- End diff --
    
    im not sure i understood this comment.
    i think you're trying to say that `plugin` can't be None here since the test for enabled
has already been performed earlier?
    the first line of the comment makes it sound like `plugin` can be None when it cant


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message