ariatosca-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ran-z <...@git.apache.org>
Subject [GitHub] incubator-ariatosca pull request #95: ARIA-92 Automatic operation task confi...
Date Thu, 13 Apr 2017 11:37:34 GMT
Github user ran-z commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/95#discussion_r111368126
  
    --- Diff: extensions/aria_extension_tosca/simple_v1_0/modeling/__init__.py ---
    @@ -352,20 +359,44 @@ def create_interface_template_model(context, service_template, interface):
         return model if model.operation_templates else None
     
     
    -def create_operation_template_model(context, service_template, operation): # pylint:
disable=unused-argument
    +def create_operation_template_model(context, service_template, operation):
         model = OperationTemplate(name=operation._name)
     
         if operation.description:
             model.description = operation.description.value
     
         implementation = operation.implementation
    -    if (implementation is not None) and operation.implementation.primary:
    -        model.plugin_specification, model.implementation = \
    -            parse_implementation_string(context, service_template, operation.implementation.primary)
    -
    +    if implementation is not None: 
    +        primary = implementation.primary
    +        plugin_name, model.implementation = split_prefix(primary)
    +        if plugin_name is not None:
    +            model.plugin_specification = service_template.plugin_specifications.get(plugin_name)
    +            if model.plugin_specification is None:
    +                context.validation.report(
    +                    'unknown plugin "%s" specified in operation implementation: %s'
    +                    % (plugin_name, primary),
    +                    locator=operation._get_child_locator('implementation', 'primary'),
    +                    level=Issue.BETWEEN_TYPES)
    +    
    +        relationship_edge = operation._get_extensions(context).get('relationship_edge')
    +        if relationship_edge is not None:
    --- End diff --
    
    Don't you think it'd be better to have it be set to `source` by default?
    I assume when it's `None` we should treat it as `source`, so I think it'd be better if
the data model reflects this design decision, no?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message