ariatosca-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tliron <...@git.apache.org>
Subject [GitHub] incubator-ariatosca pull request #95: ARIA-92 Automatic operation task confi...
Date Wed, 05 Apr 2017 15:47:46 GMT
Github user tliron commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/95#discussion_r109947108
  
    --- Diff: tests/modeling/test_models.py ---
    @@ -583,48 +583,49 @@ def test_node_model_creation(self, node_template_storage, is_valid,
name, runtim
                        node_template_storage.service.list()[0]
     
     
    -class TestNodeIP(object):
    +class TestNodeHostAddress(object):
    --- End diff --
    
    That whole part of the code (finding the "ip") had to be refactored because it was essentially
broken. As I was changing it anyway it made sense to change the name. It's really not hard
to change back.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message