ariatosca-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tliron <...@git.apache.org>
Subject [GitHub] incubator-ariatosca pull request #95: ARIA-92 Automatic operation task confi...
Date Wed, 05 Apr 2017 15:47:46 GMT
Github user tliron commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/95#discussion_r109950298
  
    --- Diff: aria/modeling/service_instance.py ---
    @@ -529,6 +524,32 @@ def validate_capabilities(self):
                     satisfied = False
             return satisfied
     
    +    def find_host(self):
    +        def _find_host(node):
    --- End diff --
    
    If we do that then we'll be calling `find_host` again on again on the same nodes that
are targets of different relationships. So, to do that efficiently we would need some extra
flag (`found_host`?) to signify that we don't have to do that again for that node. It made
more sense to me to have it set once and only once per node.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message