ariatosca-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ran-z <...@git.apache.org>
Subject [GitHub] incubator-ariatosca pull request #95: ARIA-92 Automatic operation task confi...
Date Wed, 05 Apr 2017 10:15:01 GMT
Github user ran-z commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/95#discussion_r109878912
  
    --- Diff: aria/orchestrator/workflows/api/task.py ---
    @@ -65,86 +65,82 @@ def __init__(self,
                      actor,
                      actor_type,
                      interface_name,
    -                 operation_name,
    -                 runs_on=None,
    +                 operation_name, # remove configuration
    +                 inputs=None,
                      max_attempts=None,
                      retry_interval=None,
    -                 ignore_failure=None,
    -                 inputs=None):
    +                 ignore_failure=None):
             """
             Do not call this constructor directly. Instead, use :meth:`for_node` or
             :meth:`for_relationship`.
             """
     
    -        assert isinstance(actor, (models.Node, models.Relationship))
    -        assert actor_type in ('node', 'relationship')
             assert interface_name and operation_name
    -        assert runs_on in models.Task.RUNS_ON
             super(OperationTask, self).__init__()
     
             self.actor = actor
    +        self.actor_type = actor_type
    --- End diff --
    
    why are any changes needed here (besides runs_on)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message