ariatosca-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARIA-105) Integrate new models into parser
Date Mon, 13 Mar 2017 13:20:41 GMT

    [ https://issues.apache.org/jira/browse/ARIA-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15907447#comment-15907447
] 

ASF GitHub Bot commented on ARIA-105:
-------------------------------------

Github user mxmrlv commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/72#discussion_r105656646
  
    --- Diff: aria/modeling/service_instance.py ---
    @@ -192,21 +193,21 @@ def get_group_ids(self, group_template_name):
             return collections.FrozenList((group.name
                                            for group in self.find_groups(group_template_name)))
     
    -    def is_node_a_target(self, context, target_node):
    +    def is_node_a_target(self, target_node):
             for node in self.nodes:
    -            if self._is_node_a_target(context, node, target_node):
    +            if self._is_node_a_target(node, target_node):
                     return True
             return False
     
    -    def _is_node_a_target(self, context, source_node, target_node):
    -        if source_node.relationships:
    -            for relationship in source_node.relationships:
    -                if relationship.target_node_id == target_node.name:
    +    def _is_node_a_target(self, source_node, target_node):
    +        if source_node.outbound_relationships:
    --- End diff --
    
    if source_node.outbound_relationships.filter_by(target_node_name=target_node.name):...


> Integrate new models into parser
> --------------------------------
>
>                 Key: ARIA-105
>                 URL: https://issues.apache.org/jira/browse/ARIA-105
>             Project: AriaTosca
>          Issue Type: Task
>            Reporter: Ran Ziv
>            Assignee: Tal Liron
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message