ariatosca-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxmrlv <...@git.apache.org>
Subject [GitHub] incubator-ariatosca pull request #72: ARIA-105 integrate modeling
Date Sun, 19 Mar 2017 13:30:37 GMT
Github user mxmrlv commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/72#discussion_r106804940
  
    --- Diff: aria/orchestrator/workflows/builtin/utils.py ---
    @@ -14,33 +14,38 @@
     # limitations under the License.
     
     from ..api.task import OperationTask
    +from .. import exceptions
     
     
    -def create_node_task(operation_name, node):
    +def create_node_task(interface_name, operation_name, node):
         """
         Returns a new operation task if the operation exists in the node, otherwise returns
None.
         """
     
    -    if _has_operation(node.interfaces, operation_name):
    -        return OperationTask.node(instance=node,
    -                                  name=operation_name)
    -    return None
    +    try:
    +        return OperationTask.for_node(node=node,
    +                                      interface_name=interface_name,
    +                                      operation_name=operation_name)
    +    except exceptions.TaskException:
    --- End diff --
    
    This might catch things we don't want to catch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message