ariatosca-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxmrlv <...@git.apache.org>
Subject [GitHub] incubator-ariatosca pull request #72: Aria 105 integrate modeling
Date Sun, 05 Mar 2017 14:17:03 GMT
Github user mxmrlv commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/72#discussion_r104313485
  
    --- Diff: aria/orchestrator/workflows/api/task.py ---
    @@ -69,21 +70,38 @@ def __init__(self,
                      ignore_failure=None,
                      inputs=None,
                      plugin=None,
    -                 runs_on=None):
    +                 runs_on=None,
    +                 dry=False):
             """
             Creates an operation task using the name, details, node instance and any additional
kwargs.
    -        :param name: the operation of the name.
    +
    +        :param name: the name of the operation.
             :param actor: the operation host on which this operation is registered.
             :param inputs: operation inputs.
             """
    -        assert isinstance(actor, (model.Node,
    -                                  model.Relationship))
    +
    +        assert isinstance(actor, (models.Node, models.Relationship))
             super(OperationTask, self).__init__()
    +
    +        if dry:
    --- End diff --
    
    why should the task know about whether it's being dry-ran or not?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message