ariatosca-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARIA-99) Straightforward end-to-end tests for parser and built-in workflow
Date Tue, 07 Feb 2017 11:54:42 GMT

    [ https://issues.apache.org/jira/browse/ARIA-99?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15855825#comment-15855825
] 

ASF GitHub Bot commented on ARIA-99:
------------------------------------

Github user ran-z commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/67#discussion_r99804425
  
    --- Diff: tests/orchestrator/test_complete.py ---
    @@ -0,0 +1,58 @@
    +# Licensed to the Apache Software Foundation (ASF) under one or more
    +# contributor license agreements.  See the NOTICE file distributed with
    +# this work for additional information regarding copyright ownership.
    +# The ASF licenses this file to You under the Apache License, Version 2.0
    +# (the "License"); you may not use this file except in compliance with
    +# the License.  You may obtain a copy of the License at
    +#
    +#     http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing, software
    +# distributed under the License is distributed on an "AS IS" BASIS,
    +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +# See the License for the specific language governing permissions and
    +# limitations under the License.
    +
    +import sys
    +
    +from aria.orchestrator.runner import Runner
    +from aria.orchestrator.workflows.builtin import BUILTIN_WORKFLOWS
    +from aria.parser.modeling.storage import initialize_storage
    +from aria.utils.imports import import_fullname
    +from aria.utils.collections import OrderedDict
    +
    +from ..parser.service_templates import consume_node_cellar
    +
    +
    +WORKFLOW_POLICY_INTERNAL_PROPERTIES = ('function', 'implementation', 'dependencies')
    +
    +
    +def test_install():
    +    _workflow('install')
    +
    +
    +def test_custom():
    +    _workflow('maintenance_on')
    --- End diff --
    
    I'm not sure we should be testing custom workflows at this time, simply because we haven't
quite implemented this feature "for real" yet. It's fine to keep it, I just don't see much
benefit for it at the moment.


> Straightforward end-to-end tests for parser and built-in workflow
> -----------------------------------------------------------------
>
>                 Key: ARIA-99
>                 URL: https://issues.apache.org/jira/browse/ARIA-99
>             Project: AriaTosca
>          Issue Type: Task
>            Reporter: Tal Liron
>            Assignee: Tal Liron
>            Priority: Minor
>
> The idea is to start with a comprehensive blueprint and end up with valid results. Essentially
all mechanisms in ARIA will be tested except for the actual CLI package -- the tests will
simulate what happens when a user enters a CLI command.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message