ariatosca-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARIA-42) Implement full blown mechanism for serializing an operation context
Date Wed, 08 Feb 2017 15:24:42 GMT

    [ https://issues.apache.org/jira/browse/ARIA-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15858119#comment-15858119
] 

ASF GitHub Bot commented on ARIA-42:
------------------------------------

Github user mxmrlv commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/68#discussion_r100088894
  
    --- Diff: tests/mock/context.py ---
    @@ -15,26 +15,30 @@
     
     import aria
     from aria.orchestrator import context
    -from aria.storage.filesystem_rapi import FileSystemResourceAPI
    -from aria.storage.sql_mapi import SQLAlchemyModelAPI
    +from aria.storage import (
    +    sql_mapi,
    +    filesystem_rapi,
    +)
     
     from . import models
     from .topology import create_simple_topology_two_nodes
     
     
    -def simple(mapi_kwargs, resources_dir=None, **kwargs):
    -    model_storage = aria.application_model_storage(SQLAlchemyModelAPI, api_kwargs=mapi_kwargs)
    +def simple(tmpdir,
    +           model_initiator_kwargs=None,
    +           resources_initiator_kwargs=None,
    +           context_kwargs=None):
     
    -    deployment_id = create_simple_topology_two_nodes(model_storage)
    +    model_storage = aria.application_model_storage(
    --- End diff --
    
    be consistent with initiator passing


> Implement full blown mechanism for serializing an operation context
> -------------------------------------------------------------------
>
>                 Key: ARIA-42
>                 URL: https://issues.apache.org/jira/browse/ARIA-42
>             Project: AriaTosca
>          Issue Type: Story
>            Reporter: Dan Kilman
>            Assignee: Maxim Orlov
>
> The current mechanism at aria/orchestration/workflows/context/serialization.py is very
limited.
> It serializes/deserializes the context.model and context.resource with hard coded knowledge
of the actual implementation involved and even how they were initialized. Specifically:
> The model storage initialized is always expected to be sqlachemy based with no additional
engine configuration (i.e. only the engine url is used to re-construct the sqlalchemy engine),
similar logic applies to the instantiated sqlalchemy session.
> The resource storage initialized is always the file based resource storage.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message