ariatosca-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ran-z <...@git.apache.org>
Subject [GitHub] incubator-ariatosca pull request #67: ARIA-99 Straightforward end-to-end tes...
Date Tue, 07 Feb 2017 14:59:46 GMT
Github user ran-z commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/67#discussion_r99840345
  
    --- Diff: tests/complete/test_parser.py ---
    @@ -0,0 +1,40 @@
    +# Licensed to the Apache Software Foundation (ASF) under one or more
    +# contributor license agreements.  See the NOTICE file distributed with
    +# this work for additional information regarding copyright ownership.
    --- End diff --
    
    Actually, I'm not sure these tests should have moved out from where they were at.
    "Complete" means end to end tests; While these are not unit tests per se, they are parser
specific.
    We already have many tests which aren't standard unit tests yet are treated as such. See
execution plugin tests for example - those actually run the workflow engine.
    On the other hand, the parser might indeed be used regardless of other components of ARIA
by other projects, and so it might be ok to leave this here.
    Again, I'll leave it for your consideration.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message