ariatosca-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxmrlv <...@git.apache.org>
Subject [GitHub] incubator-ariatosca pull request #60: Aria 44 merge parser and storage model...
Date Sun, 05 Feb 2017 12:06:26 GMT
Github user mxmrlv commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/60#discussion_r99487510
  
    --- Diff: aria/orchestrator/workflows/builtin/utils.py ---
    @@ -68,3 +67,11 @@ def get_task(node_instance_id):
                         graph.add_dependency(dependency, task)
                 else:
                     graph.add_dependency(task, dependencies)
    +
    +
    +def _has_operation(interfaces, operation_name):
    +    for interface in interfaces:
    +        for operation in interface.operations:
    --- End diff --
    
    this could be replace via operations.filter_by(name=operation_name).count() == 1
    
    (no need to get all of the operations for each interface. there could be even a way to
filter on the interfaces level)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message