Mailing-List: contact dev-help@ariatosca.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ariatosca.incubator.apache.org
From: mxmrlv <git@git.apache.org>
To: dev@ariatosca.incubator.apache.org
Reply-To: dev@ariatosca.incubator.apache.org
References: <git-pr-31-incubator-ariatosca@git.apache.org>
In-Reply-To: <git-pr-31-incubator-ariatosca@git.apache.org>
Subject: [GitHub] incubator-ariatosca pull request #31: ARIA-30-SQL-based-storage-implementati...
Content-Type: text/plain
Message-Id: <20161205151548.71A39E3839@git1-us-west.apache.org>
Date: Mon,  5 Dec 2016 15:15:48 +0000 (UTC)
archived-at: Mon, 05 Dec 2016 15:15:53 -0000

Github user mxmrlv commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/31#discussion_r90883621
  
    --- Diff: tests/storage/__init__.py ---
    @@ -31,9 +32,10 @@ def teardown_method(self):
             rmtree(self.path, ignore_errors=True)
     
     
    -def get_sqlite_api_params():
    +def get_sqlite_api_kwargs():
         engine = create_engine('sqlite:///:memory:',
                                connect_args={'check_same_thread': False},
                                poolclass=StaticPool)
         session = orm.sessionmaker(bind=engine)()
    +    MetaData().create_all(engine)
    --- End diff --
    
    try through base


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---